linux-kernel - Re: [tip: x86/urgent] x86/sev: Do not touch VMSA pages during SNP guest memory kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250514093055.GDaCRiz6rY7f71YnIr@fat_crate.local>
Date: Wed, 14 May 2025 11:30:55 +0200
From: Borislav Petkov <bp@...en8.de>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
	Ashish Kalra <ashish.kalra@....com>,
	Pankaj Gupta <pankaj.gupta@....com>,
	Tom Lendacky <thomas.lendacky@....com>,
	Srikanth Aithal <sraithal@....com>, stable@...r.kernel.org,
	x86@...nel.org
Subject: Re: [tip: x86/urgent] x86/sev: Do not touch VMSA pages during SNP
 guest memory kdump

On Wed, May 14, 2025 at 11:15:41AM +0200, Ingo Molnar wrote:
> imply that you don't accept the other issues my review identified, such as
> the messy type conversions and the inconsistent handling of svsm_caa_pa as
> valid? That would be sad.

Another proof that you're not really reading my emails:

"Feel free to propose fixes, Tom and I will review them and even test them for
you!"

> Secondly, the fact that half of the patch is moving/refactoring code, 
> while the other half is adding new code is no excuse to ignore review 
> feedback for the code that gets moved/refactored - reviewers obviously 
> need to read and understand the code that gets moved too. This is 
> kernel maintenance 101.

See above.

> All these problems accumulate and may result in fragility and bugs.

LOL, this is very ironic coming from you: to talk about problems accumulating
from patches *you* applied without anyone else reviewing. Hillarious.

> Oh wow, you really don't take constructive criticism of patches very 
> well. Review feedback isn't a personal attack against you. Please don't 
> shoot the messenger.

Sorry, the time for constructive criticism with you is long over. You have
proved yourself over and over again that normal way of working with you just
doesn't fly.

I have told you here why it is ok to do this patch this way. You ignored it.

This patch was tested with everything we've got. No issues.

I suggested you propose changes to that code and we will review and test them.
You ignore that too.

Well, ignoring people goes both ways.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette