linux-kernel - Re: [PATCH v2 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0c0fc86-844f-4006-851c-31a092a6bb08@kernel.org>
Date: Wed, 14 May 2025 11:59:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sangwook Shin <sw617.shin@...sung.com>, alim.akhtar@...sung.com,
 wim@...ux-watchdog.org, linux@...ck-us.net
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 Kyunghwan Seo <khwan.seo@...sung.com>
Subject: Re: [PATCH v2 1/5] watchdog: s3c2410_wdt: Replace hardcoded values
 with macro definitions

On 14/05/2025 11:42, Sangwook Shin wrote:
> Modify the code to utilize macro-defined values instead of hardcoded
> values. The value 0x100 in the s3c2410wdt_set_heartbeat function represents
> S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its meaning
> difficult to understand and reducing code readability.
> 
> Signed-off-by: Sangwook Shin <sw617.shin@...sung.com>
> Signed-off-by: Kyunghwan Seo <khwan.seo@...sung.com>
Your DCO is not looking correct. You must be the last signing person.
What is actually Kyunghwan's contribution here and what does his SoB
mean? Who wrote the patch?

Best regards,
Krzysztof