linux-kernel - Re: [EXT] Re: [PATCH v2 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4317fef-c4e9-405c-9bcb-4d5447dd8367@kernel.org>
Date: Wed, 14 May 2025 12:05:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aman Kumar Pandey <aman.kumarpandey@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
 "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
 <robh@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Cc: Vikash Bansal <vikash.bansal@....com>,
 Priyanka Jain <priyanka.jain@....com>,
 Shashank Rebbapragada <shashank.rebbapragada@....com>,
 Frank Li <frank.li@....com>
Subject: Re: [EXT] Re: [PATCH v2 2/2] drivers: i3c: Add driver for NXP P3H2x4x
 i3c-hub device

On 12/05/2025 13:45, Aman Kumar Pandey wrote:
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Thursday, May 8, 2025 11:40 AM
>> To: Aman Kumar Pandey <aman.kumarpandey@....com>; linux-
>> kernel@...r.kernel.org; linux-i3c@...ts.infradead.org;
>> alexandre.belloni@...tlin.com; krzk+dt@...nel.org; robh@...nel.org;
>> conor+dt@...nel.org; devicetree@...r.kernel.org
>> Cc: Vikash Bansal <vikash.bansal@....com>; Priyanka Jain
>> <priyanka.jain@....com>; Shashank Rebbapragada
>> <shashank.rebbapragada@....com>; Frank Li <frank.li@....com>
>> Subject: [EXT] Re: [PATCH v2 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-
>> hub device
>>
>> [Some people who received this message don't often get email from
>> krzk@...nel.org. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 08/05/2025 06:57, Aman Kumar Pandey wrote:
>>> +
>>> +static void p3h2x4x_of_get_tp_dt_conf(struct device *dev,
>>> +                                   const struct device_node *node) {
>>> +     struct p3h2x4x *priv = dev_get_drvdata(dev);
>>> +     struct device_node *dev_node;
>>> +     u64 tp_port;
>>> +
>>> +     for_each_available_child_of_node(node, dev_node) {
>>> +             if (!dev_node->name || of_node_cmp(dev_node->name,
>>> + "target-port"))
>>
>>
>> Same NAK as before. You ignored the comment and nothing improved.
>>
> 
> Thanks for reviewing the patch.
> As per your comment I have used proper function to get reg instead of sscanf. And our driver is not having direct interface with userspace.

What was the comment - undocumented ABI.

> What should I change here ?

How did you solve that comment?


Best regards,
Krzysztof