linux-kernel - Re: [PATCH v3 1/2] dt-bindings: pinctrl: eswin: Document for EIC7700 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbd7de92-e182-4a37-b7bc-7424fa4684bf@kernel.org>
Date: Wed, 14 May 2025 12:30:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yulin Lu <luyulin@...incomputing.com>, linus.walleij@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kees@...nel.org, gustavoars@...nel.org,
 brgl@...ev.pl, linux-hardening@...r.kernel.org
Cc: ningyu@...incomputing.com, zhengyu@...incomputing.com,
 linmin@...incomputing.com, huangyifeng@...incomputing.com,
 fenglin@...incomputing.com, lianghujun@...incomputing.com,
 Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: eswin: Document for EIC7700
 SoC

On 14/05/2025 10:11, Yulin Lu wrote:
> +
> +          - if:
> +              properties:
> +                pins:
> +                  anyOf:
> +                    - pattern: '^rgmii'
> +                    - const: lpddr_ref_clk
> +            then:
> +              properties:
> +                drive-strength-microamp:
> +                  enum: [3000, 6000, 9000, 12000, 15000, 18000, 21000, 24000]
> +            else:
> +              properties:
> +                drive-strength-microamp:
> +                  enum: [6000, 9000, 12000, 15000, 18000, 21000, 24000, 27000]
> +
> +

Just one blank line

> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pinctrl@...00080 {
> +      compatible = "eswin,eic7700-pinctrl";
> +      reg = <0x51600080 0x1fff80>;
> +      vrgmii-supply = <&vcc_1v8>;
> +
> +      dev-active-grp{

Missing space before {


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

> +    };


Best regards,
Krzysztof