linux-kernel - Re: [PATCH v2] phy: qcom-qmp-usb: Fix an NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174722263664.85510.7245285831911062529.b4-ty@kernel.org>
Date: Wed, 14 May 2025 12:37:16 +0100
From: Vinod Koul <vkoul@...nel.org>
To: kishon@...nel.org, lumag@...nel.org, quic_kriskura@...cinc.com, 
 manivannan.sadhasivam@...aro.org, konrad.dybcio@....qualcomm.com, 
 quic_varada@...cinc.com, quic_kbajaj@...cinc.com, johan+linaro@...nel.org, 
 Chenyuan Yang <chenyuan0y@...il.com>
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>, 
 Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v2] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug


On Mon, 14 Apr 2025 07:50:50 -0500, Chenyuan Yang wrote:
> The qmp_usb_iomap() helper function currently returns the raw result of
> devm_ioremap() for non-exclusive mappings. Since devm_ioremap() may return
> a NULL pointer and the caller only checks error pointers with IS_ERR(),
> NULL could bypass the check and lead to an invalid dereference.
> 
> Fix the issue by checking if devm_ioremap() returns NULL. When it does,
> qmp_usb_iomap() now returns an error pointer via IOMEM_ERR_PTR(-ENOMEM),
> ensuring safe and consistent error handling.
> 
> [...]

Applied, thanks!

[1/1] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug
      commit: d14402a38c2d868cacb1facaf9be908ca6558e59

Best regards,
-- 
~Vinod