| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a9846381-96a1-436d-892d-79eecec2a272@whut.edu.cn>
Date: Wed, 14 May 2025 19:54:24 +0800
From: Ze Huang <huangze@...t.edu.cn>
To: Vinod Koul <vkoul@...nel.org>
Cc: Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
Philipp Zabel <p.zabel@...gutronix.de>, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] phy: spacemit: support K1 USB2.0 PHY controller
On 5/14/25 4:51 PM, Vinod Koul wrote:
> Hi,
>
> On 18-04-25, 21:19, Ze Huang wrote:
>> Add support for SpacemiT K1 USB2.0 PHY.
> Can you please add more details of this device, which SoC is this, and
> what are the capablities of this phy
Hi, Vinod, thank you for the comments!
How about these:
The SpacemiT K1 SoC includes three USB ports:
- One USB2.0 OTG port
- One USB2.0 host-only port
- One USB3.0 port with an integrated USB2.0 DRD interface
Each of these ports is connected to a USB2.0 PHY responsible for
USB2 transmission.
This commit adds support for the SpacemiT K1 USB2.0 PHY, which is
compliant
with the USB 2.0 specification and supports both 8-bit 60MHz and
16-bit 30MHz
parallel interfaces.
>> Signed-off-by: Ze Huang <huangze@...t.edu.cn>
>> ---
>> drivers/phy/Kconfig | 1 +
>> drivers/phy/Makefile | 1 +
>> drivers/phy/spacemit/Kconfig | 13 ++++
>> drivers/phy/spacemit/Makefile | 2 +
>> drivers/phy/spacemit/phy-k1-usb2.c | 131 +++++++++++++++++++++++++++++++++++++
>> 5 files changed, 148 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 8d58efe998ec5fd50054eed2c90d6ecce6bd5dd8..fca589aa7926eb5bce14e99785cf32cf0395202e 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -114,6 +114,7 @@ source "drivers/phy/renesas/Kconfig"
>> source "drivers/phy/rockchip/Kconfig"
>> source "drivers/phy/samsung/Kconfig"
>> source "drivers/phy/socionext/Kconfig"
>> +source "drivers/phy/spacemit/Kconfig"
>> source "drivers/phy/st/Kconfig"
>> source "drivers/phy/starfive/Kconfig"
>> source "drivers/phy/sunplus/Kconfig"
>> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
>> index e281442acc752820fe0bd638dfe38986a37c2a78..05993ff8a15daf7e2583b5f9b9b37ac584a30609 100644
>> --- a/drivers/phy/Makefile
>> +++ b/drivers/phy/Makefile
>> @@ -34,6 +34,7 @@ obj-y += allwinner/ \
>> rockchip/ \
>> samsung/ \
>> socionext/ \
>> + spacemit/ \
>> st/ \
>> starfive/ \
>> sunplus/ \
>> diff --git a/drivers/phy/spacemit/Kconfig b/drivers/phy/spacemit/Kconfig
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..0136aee2e8a2f5f484da136b26f80130794b992c
>> --- /dev/null
>> +++ b/drivers/phy/spacemit/Kconfig
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# Phy drivers for SpacemiT platforms
>> +#
>> +config PHY_SPACEMIT_K1_USB2
>> + tristate "SpacemiT K1 USB 2.0 PHY support"
>> + depends on (ARCH_SPACEMIT || COMPILE_TEST) && OF
>> + depends on COMMON_CLK
>> + depends on USB_COMMON
>> + select GENERIC_PHY
>> + help
>> + Enable this to support K1 USB 2.0 PHY driver. This driver takes care of
>> + enabling and clock setup and will be used by K1 udc/ehci/otg/xhci driver.
>> diff --git a/drivers/phy/spacemit/Makefile b/drivers/phy/spacemit/Makefile
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..fec0b425a948541b39b814caef0b05e1e002d92f
>> --- /dev/null
>> +++ b/drivers/phy/spacemit/Makefile
>> @@ -0,0 +1,2 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +obj-$(CONFIG_PHY_SPACEMIT_K1_USB2) += phy-k1-usb2.o
>> diff --git a/drivers/phy/spacemit/phy-k1-usb2.c b/drivers/phy/spacemit/phy-k1-usb2.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..4a5684f3185f61f9d865b0fb52644bb280756d00
>> --- /dev/null
>> +++ b/drivers/phy/spacemit/phy-k1-usb2.c
>> @@ -0,0 +1,131 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * SpacemiT K1 USB 2.0 PHY driver
>> + *
>> + * Copyright (C) 2025 SpacemiT (Hangzhou) Technology Co. Ltd
>> + * Copyright (C) 2025 Ze Huang <huangze@...t.edu.cn>
>> + */
>> +
>> +#include <linux/clk.h>
>> +#include <linux/iopoll.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/usb/of.h>
>> +
>> +#define USB2_PHY_REG01 0x04
>> +#define USB2_PHY_REG01_VAL 0x60ef
>> +#define USB2_PHY_REG01_PLL_IS_READY BIT(0)
>> +#define USB2_PHY_REG04 0x10
>> +#define USB2_PHY_REG04_AUTO_CLEAR_DIS BIT(2)
>> +#define USB2_PHY_REG0D 0x34
>> +#define USB2_PHY_REG0D_VAL 0x1c
>> +#define USB2_PHY_REG26 0x98
>> +#define USB2_PHY_REG26_VAL 0xbec4
> What are these values referred to, why are you defining fixed values for
> driver to use and not set the register bits?
At the moment, documentation[1] for the USB2.0/USB3.0 PHY is
incomplete and does not include detailed register definitions.
The fixed values here are derived from the vendor driver and
reflect the required initialization for the PHY to operate correctly on K1.
Link:
https://developer.spacemit.com/documentation?token=AjHDwrW78igAAEkiHracBI9HnTb
[1]
>> +
>> +#define USB2D_CTRL_RESET_TIME_MS 50
>> +
>> +struct spacemit_usb2phy {
>> + struct phy *phy;
>> + struct clk *clk;
>> + void __iomem *base;
>> +};
>> +
>> +static int spacemit_usb2phy_init(struct phy *phy)
>> +{
>> + struct spacemit_usb2phy *sphy = phy_get_drvdata(phy);
>> + void __iomem *base = sphy->base;
>> + u32 val;
>> + int ret;
>> +
>> + ret = clk_prepare_enable(sphy->clk);
>> + if (ret) {
>> + dev_err(&phy->dev, "failed to enable clock\n");
>> + return ret;
>> + }
>> +
>> + /*
>> + * make sure the usb controller is not under reset process before
>> + * any configuration
>> + */
>> + usleep_range(150, 200);
>> + writel(USB2_PHY_REG26_VAL, base + USB2_PHY_REG26); /* 24M ref clk */
>> +
>> + ret = read_poll_timeout(readl, val, (val & USB2_PHY_REG01_PLL_IS_READY),
>> + 500, USB2D_CTRL_RESET_TIME_MS * 1000, true,
>> + base + USB2_PHY_REG01);
>> + if (ret) {
>> + dev_err(&phy->dev, "wait PHY_REG01[PLLREADY] timeout\n");
>> + return ret;
>> + }
>> +
>> + /* release usb2 phy internal reset and enable clock gating */
>> + writel(USB2_PHY_REG01_VAL, base + USB2_PHY_REG01);
>> + writel(USB2_PHY_REG0D_VAL, base + USB2_PHY_REG0D);
>> +
>> + /* auto clear host disc */
>> + val = readl(base + USB2_PHY_REG04);
>> + val |= USB2_PHY_REG04_AUTO_CLEAR_DIS;
>> + writel(val, base + USB2_PHY_REG04);
>> +
>> + return 0;
>> +}
>> +
>> +static int spacemit_usb2phy_exit(struct phy *phy)
>> +{
>> + struct spacemit_usb2phy *sphy = phy_get_drvdata(phy);
>> +
>> + clk_disable_unprepare(sphy->clk);
>> +
>> + return 0;
>> +}
>> +
>> +static const struct phy_ops spacemit_usb2phy_ops = {
>> + .init = spacemit_usb2phy_init,
>> + .exit = spacemit_usb2phy_exit,
>> + .owner = THIS_MODULE,
>> +};
>> +
>> +static int spacemit_usb2phy_probe(struct platform_device *pdev)
>> +{
>> + struct phy_provider *phy_provider;
>> + struct device *dev = &pdev->dev;
>> + struct spacemit_usb2phy *sphy;
>> +
>> + sphy = devm_kzalloc(dev, sizeof(*sphy), GFP_KERNEL);
>> + if (!sphy)
>> + return -ENOMEM;
>> +
>> + sphy->clk = devm_clk_get_prepared(&pdev->dev, NULL);
>> + if (IS_ERR(sphy->clk))
>> + return dev_err_probe(dev, PTR_ERR(sphy->clk), "Failed to get clock\n");
>> +
>> + sphy->base = devm_platform_ioremap_resource(pdev, 0);
>> + if (IS_ERR(sphy->base))
>> + return PTR_ERR(sphy->base);
>> +
>> + sphy->phy = devm_phy_create(dev, NULL, &spacemit_usb2phy_ops);
>> + if (IS_ERR(sphy->phy))
>> + return dev_err_probe(dev, PTR_ERR(sphy->phy), "Failed to create phy\n");
>> +
>> + phy_set_drvdata(sphy->phy, sphy);
>> + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>> +
>> + return PTR_ERR_OR_ZERO(phy_provider);
>> +}
>> +
>> +static const struct of_device_id spacemit_usb2phy_dt_match[] = {
>> + { .compatible = "spacemit,k1-usb2-phy", },
>> + { /* sentinal */ }
>> +};
>> +MODULE_DEVICE_TABLE(of, spacemit_usb2phy_dt_match);
>> +
>> +static struct platform_driver spacemit_usb2_phy_driver = {
>> + .probe = spacemit_usb2phy_probe,
>> + .driver = {
>> + .name = "spacemit-usb2-phy",
>> + .of_match_table = spacemit_usb2phy_dt_match,
>> + },
>> +};
>> +module_platform_driver(spacemit_usb2_phy_driver);
>> +
>> +MODULE_DESCRIPTION("Spacemit USB 2.0 PHY driver");
>> +MODULE_LICENSE("GPL");
>>
>> --
>> 2.49.0
>>
>>
>> --
>> linux-phy mailing list
>> linux-phy@...ts.infradead.org
>> https://lists.infradead.org/mailman/listinfo/linux-phy
Powered by blists - more mailing lists