linux-kernel - [PATCH] ASoC: amd: acp: Add null pointer check in acp_max98388_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250514120939.581-1-vulab@iscas.ac.cn>
Date: Wed, 14 May 2025 20:09:39 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: lgirdwood@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com
Cc: Vijendar.Mukunda@....com,
	mario.limonciello@....com,
	venkataprasad.potturu@....com,
	gregkh@...uxfoundation.org,
	kuninori.morimoto.gx@...esas.com,
	peterz@...radead.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] ASoC: amd: acp: Add null pointer check in acp_max98388_hw_paramsi()

The acp_max98388_hw_params() calls the snd_soc_card_get_codec_dai(),
but does not check its return value which is a null pointer if the
function fails. This can result in a null pointer dereference.

Add a null pointer check for snd_soc_card_get_codec_dai() to avoid null
pointer dereference when the function fails.

Fixes: ac91c8c89782 ("ASoC: amd: acp: Add machine driver support for max98388 codec")
Cc: stable@...r.kernel.org # v6.6
Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 sound/soc/amd/acp/acp-mach-common.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
index f7602c1769bf..a795cc1836cc 100644
--- a/sound/soc/amd/acp/acp-mach-common.c
+++ b/sound/soc/amd/acp/acp-mach-common.c
@@ -918,6 +918,9 @@ static int acp_max98388_hw_params(struct snd_pcm_substream *substream,
 						   MAX98388_CODEC_DAI);
 	int ret;
 
+	if (codec_dai)
+		return -EINVAL;
+
 	ret = snd_soc_dai_set_fmt(codec_dai,
 				  SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_I2S |
 				  SND_SOC_DAIFMT_NB_NF);
-- 
2.42.0.windows.2