linux-kernel - Re: [PATCH v3] drm/vmwgfx: Use non-hybrid PCI devres API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABQX2QNQbO4dMq-Hi6tvpi7OTwcVfjM62eCr1OGkzF8Phy-Shw@mail.gmail.com>
Date: Wed, 14 May 2025 08:42:35 -0400
From: Zack Rusin <zack.rusin@...adcom.com>
To: Philipp Stanner <phasta@...nel.org>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] drm/vmwgfx: Use non-hybrid PCI devres API

On Wed, May 14, 2025 at 3:31 AM Philipp Stanner <phasta@...nel.org> wrote:
>
> vmwgfx enables its PCI device with pcim_enable_device(). This,
> implicitly, switches the function pci_request_regions() into managed
> mode, where it becomes a devres function.
>
> The PCI subsystem wants to remove this hybrid nature from its
> interfaces. To do so, users of the aforementioned combination of
> functions must be ported to non-hybrid functions.
>
> Moreover, since both functions are already managed in this driver, the
> calls to pci_release_regions() are unnecessary.
>
> Remove the calls to pci_release_regions().
>
> Replace the call to sometimes-managed pci_request_regions() with one to
> always-managed pcim_request_all_regions().
>
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> Reviewed-by: Zack Rusin <zack.rusin@...adcom.com>
> ---
> Changes in v3:
>   - Use the correct driver name in the commit message. (Zack)
>
> Changes in v2:
>   - Fix unused variable error.

Thank you! I've pushed it to drm-misc-next.

z

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5414 bytes)