linux-kernel - Re: [PATCH 1/2] dt-bindings: clock: eswin: Documentation for eic7700 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250514124314.GA1770882-robh@kernel.org>
Date: Wed, 14 May 2025 07:43:14 -0500
From: Rob Herring <robh@...nel.org>
To: dongxuyang@...incomputing.com
Cc: mturquette@...libre.com, sboyd@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	ningyu@...incomputing.com, linmin@...incomputing.com,
	huangyifeng@...incomputing.com
Subject: Re: [PATCH 1/2] dt-bindings: clock: eswin: Documentation for eic7700
 SoC

On Wed, May 14, 2025 at 08:25:16AM +0800, dongxuyang@...incomputing.com wrote:
> From: Xuyang Dong <dongxuyang@...incomputing.com>
> 
> Add device tree binding documentation and header file for
> the ESWIN EIC7700 clock controller module.
> 
> Signed-off-by: Yifeng Huang <huangyifeng@...incomputing.com>
> Signed-off-by: Xuyang Dong <dongxuyang@...incomputing.com>
> ---
>  .../bindings/clock/eswin,eic7700-clock.yaml   |  43 ++
>  .../dt-bindings/clock/eswin,eic7700-clock.h   | 588 ++++++++++++++++++
>  2 files changed, 641 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/eswin,eic7700-clock.yaml
>  create mode 100644 include/dt-bindings/clock/eswin,eic7700-clock.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/eswin,eic7700-clock.yaml b/Documentation/devicetree/bindings/clock/eswin,eic7700-clock.yaml
> new file mode 100644
> index 000000000000..c39fa99b503c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/eswin,eic7700-clock.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/eswin,eic7700-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Eswin EIC7700 SoC clock controller
> +
> +maintainers:
> +  - Yifeng Huang <huangyifeng@...incomputing.com>
> +  - Xuyang Dong <dongxuyang@...incomputing.com>
> +
> +description: |

Don't need '|'.

> +  The clock controller registers are part of the syscrg block on
> +  eic7700 SoC.

Wrap at 80

> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: eswin,eic7700-clock

Drop 'oneOf' and 'items'.

> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/eswin,eic7700-clock.h>
> +
> +    sys_crg: sys-crg@...28000 {
> +        compatible = "syscon", "simple-mfd";

Must have a specific compatible for the block.

> +        reg = <0x000000 0x51828000 0x000000 0x80000>;
> +        clock: clock-controller {
> +            compatible = "eswin,eic7700-clock";
> +            #clock-cells = <1>;

There's no need for a child node here. Just add '#clock-cells' to the 
parent node.

> +        };
> +    };