| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <174722778588.1826217.8453984370826167855.robh@kernel.org>
Date: Wed, 14 May 2025 08:11:06 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Christian Bruel <christian.bruel@...s.st.com>
Cc: linux-arm-kernel@...ts.infradead.org, p.zabel@...gutronix.de,
mcoquelin.stm32@...il.com, linux-stm32@...md-mailman.stormreply.com,
bhelgaas@...gle.com, kw@...ux.com, johan+linaro@...nel.org,
linux-pci@...r.kernel.org, quic_schintav@...cinc.com,
alexandre.torgue@...s.st.com, manivannan.sadhasivam@...aro.org,
conor+dt@...nel.org, devicetree@...r.kernel.org, cassel@...nel.org,
shradha.t@...sung.com, linux-kernel@...r.kernel.org,
thippeswamy.havalige@....com, lpieralisi@...nel.org, krzk+dt@...nel.org
Subject: Re: [PATCH v9 0/9] Add STM32MP25 PCIe drivers
On Wed, 14 May 2025 11:15:21 +0200, Christian Bruel wrote:
> Changes in v9:
> - Describe atu and dbi2 shadowed registers in pcie_ep node
> Address RC and EP drivers comments from Manivanna:
> - Use dev_error_probe() for pm_runtime_enable() calls
> - Reword Kconfig help message
> - Move pm_runtime_get_noresume() before devm_pm_runtime_enable()
>
> Changes in v8:
> - Whitespace in comment
>
> Changes in v7:
> - Use device_init_wakeup to enable wakeup
> - Fix comments (Bjorn)
>
> Changes in v6:
> - Call device_wakeup_enable() to fix WAKE# wakeup.
> Address comments from Manivanna:
> - Fix/Add Comments
> - Fix DT indents
> - Remove dw_pcie_ep_linkup() in EP start link
> - Add PCIE_T_PVPERL_MS delay in RC PERST# deassert
>
> Changes in v5:
> Address driver comments from Manivanna:
> - Use dw_pcie_{suspend/resume}_noirq instead of private ones.
> - Move dw_pcie_host_init() to probe
> - Add stm32_remove_pcie_port cleanup function
> - Use of_node_put in stm32_pcie_parse_port
> - Remove wakeup-source property
> - Use generic dev_pm_set_dedicated_wake_irq to support wake# irq
>
> Changes in v4:
> Address bindings comments Rob Herring
> - Remove phy property form common yaml
> - Remove phy-name property
> - Move wake_gpio and reset_gpio to the host root port
>
> Changes in v3:
> Address comments from Manivanna, Rob and Bjorn:
> - Move host wakeup helper to dwc core (Mani)
> - Drop num-lanes=<1> from bindings (Rob)
> - Fix PCI address of I/O region (Mani)
> - Moved PHY to a RC rootport subsection (Bjorn, Mani)
> - Replaced dma-limit quirk by dma-ranges property (Bjorn)
> - Moved out perst assert/deassert from start/stop link (Mani)
> - Drop link_up test optim (Mani)
> - DT and comments rephrasing (Bjorn)
> - Add dts entries now that the combophy entries has landed
> - Drop delaying Configuration Requests
>
> Changes in v2:
> - Fix st,stm32-pcie-common.yaml dt_binding_check
>
> Changes in v1:
> Address comments from Rob Herring and Bjorn Helgaas:
> - Drop st,limit-mrrs and st,max-payload-size from this patchset
> - Remove single reset and clocks binding names and misc yaml cleanups
> - Split RC/EP common bindings to a separate schema file
> - Use correct PCIE_T_PERST_CLK_US and PCIE_T_RRS_READY_MS defines
> - Use .remove instead of .remove_new
> - Fix bar reset sequence in EP driver
> - Use cleanup blocks for error handling
> - Cosmetic fixes
>
> Christian Bruel (9):
> dt-bindings: PCI: Add STM32MP25 PCIe Root Complex bindings
> PCI: stm32: Add PCIe host support for STM32MP25
> dt-bindings: PCI: Add STM32MP25 PCIe Endpoint bindings
> PCI: stm32: Add PCIe Endpoint support for STM32MP25
> MAINTAINERS: add entry for ST STM32MP25 PCIe drivers
> arm64: dts: st: add PCIe pinctrl entries in stm32mp25-pinctrl.dtsi
> arm64: dts: st: Add PCIe Root Complex mode on stm32mp251
> arm64: dts: st: Add PCIe Endpoint mode on stm32mp251
> arm64: dts: st: Enable PCIe on the stm32mp257f-ev1 board
>
> .../bindings/pci/st,stm32-pcie-common.yaml | 33 ++
> .../bindings/pci/st,stm32-pcie-ep.yaml | 67 +++
> .../bindings/pci/st,stm32-pcie-host.yaml | 112 +++++
> MAINTAINERS | 7 +
> arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 20 +
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 57 +++
> arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 21 +
> drivers/pci/controller/dwc/Kconfig | 24 +
> drivers/pci/controller/dwc/Makefile | 2 +
> drivers/pci/controller/dwc/pcie-stm32-ep.c | 411 ++++++++++++++++++
> drivers/pci/controller/dwc/pcie-stm32.c | 364 ++++++++++++++++
> drivers/pci/controller/dwc/pcie-stm32.h | 16 +
> 12 files changed, 1134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/st,stm32-pcie-common.yaml
> create mode 100644 Documentation/devicetree/bindings/pci/st,stm32-pcie-ep.yaml
> create mode 100644 Documentation/devicetree/bindings/pci/st,stm32-pcie-host.yaml
> create mode 100644 drivers/pci/controller/dwc/pcie-stm32-ep.c
> create mode 100644 drivers/pci/controller/dwc/pcie-stm32.c
> create mode 100644 drivers/pci/controller/dwc/pcie-stm32.h
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250514 (best guess, 5/6 blobs matched)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/st/' for 20250514091530.3249364-1-christian.bruel@...s.st.com:
arch/arm64/boot/dts/st/stm32mp257f-dk.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg: [[1212153856, 1048576], [1213202432, 1048576], [1215299584, 524288], [268435456, 134217728]] is too long
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
arch/arm64/boot/dts/st/stm32mp257f-dk.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg-names:1: 'addr_space' was expected
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
arch/arm64/boot/dts/st/stm32mp257f-dk.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg-names: ['dbi', 'dbi2', 'atu', 'addr_space'] is too long
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg: [[1212153856, 1048576], [1213202432, 1048576], [1215299584, 524288], [268435456, 134217728]] is too long
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg-names:1: 'addr_space' was expected
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: pcie-ep@...00000 (st,stm32mp25-pcie-ep): reg-names: ['dbi', 'dbi2', 'atu', 'addr_space'] is too long
from schema $id: http://devicetree.org/schemas/pci/st,stm32-pcie-ep.yaml#
Powered by blists - more mailing lists