linux-kernel - Re: [PATCH v3 1/2] rust: irq: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D9WRQGTC8G4L.3JQF3MUBD8KAR@kernel.org>
Date: Thu, 15 May 2025 15:28:58 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Danilo Krummrich" <dakr@...nel.org>, "Daniel Almeida"
 <daniel.almeida@...labora.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <benno.lossin@...ton.me>,
 "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Thomas Gleixner" <tglx@...utronix.de>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] rust: irq: add support for request_irq()

On Thu May 15, 2025 at 2:45 PM CEST, Danilo Krummrich wrote:
> On Thu, May 15, 2025 at 09:27:51AM -0300, Daniel Almeida wrote:
>> Well, not really, because this impl PinInit can be assigned to something larger
>> that is already pinned, like drm::Device::Data for example, which is (or was)
>> already behind an Arc, or any other private data in other subsystems.
>> 
>> IIUC what you proposed has yet another indirection. If we reuse the example
>> from above, that would be an Arc for the drm Data, and another Arc for the
>> handler itself?
>
> Can't you implement Handler for drm::Device::Data and e.g. make Registration
> take an Arc<T: Handler>?

Couldn't you store the registration inside of the `drm::Device::Data`?
Or is that too early in the device lifecycle?

---
Cheers,
Benno