linux-kernel - Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81b2a499-1927-4fb3-b581-a533c64507a6@baylibre.com>
Date: Thu, 15 May 2025 09:04:57 -0500
From: David Lechner <dlechner@...libre.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, nuno.sa@...log.com, andy@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding

On 5/14/25 7:21 PM, Rodrigo Gobbi wrote:
> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> Added @Jonathan as the maintainer here due a suggestion in a
> different thread for a different binding file.
> Created this yaml using the driver probe and comparing with other gyro bindings.
> Tks and regards.
> ---
>  .../iio/gyroscope/invensense,itg3200.yaml     | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> new file mode 100644
> index 000000000000..0656dbb58cf2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Invensense ITG-3200 Gyroscope
> +
> +maintainers:
> +  - Jonathan Cameron <jic23@...nel.org>
> +
> +description: |
> +  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
> +  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
> +  low-pass filter bandwidth, and a Fast-Mode I2C . Datasheet can be found here:
> +  https://invensense.tdk.com/wp-content/uploads/2015/02/ITG-3200-Register-Map.pdf

This is only the register map, not a proper datasheet, so isn't useful
for the devicetree bindings.

> +
> +properties:
> +  compatible:
> +    const: invensense,itg3200
> +
> +  reg:
> +    maxItems: 1
> +

Missing vdd-supply and vlogic-supply properties. These should be
required.

Missing clocks property for optional external clock.

We always try to make the DT bindings as complete as possible
even if the driver doesn't use all of it.

> +  interrupts:
> +    minItems: 1
> +
> +  mount-matrix:
> +    description: an optional 3x3 mounting rotation matrix.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        itg3200@68 {

           gyro@68

Generic names are preferred.

> +            compatible = "invensense,itg3200";
> +            reg = <0x68>;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&itg3200_pins>;

Probably don't need pinctrl stuff in the example.

> +            interrupt-parent = <&gpio2>;
> +            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
> +        };
> +    };