linux-kernel - Re: [PATCH] btrfs: btrfs_backref_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515144742.GH9140@twin.jikos.cz>
Date: Thu, 15 May 2025 16:47:42 +0200
From: David Sterba <dsterba@...e.cz>
To: Daniel Vacek <neelx@...e.com>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: btrfs_backref_link_edge() cleanup

Please write more descriptive subject lines, related to what is being
cleaned up, and not just a generic "function() cleanup".

On Wed, May 14, 2025 at 03:12:39PM +0200, Daniel Vacek wrote:
> This function is always called with the LINK_LOWER argument. Thus we can
> simplify it and remove the LINK_LOWER and LINK_UPPER macros.
> 
> The last call with LINK_UPPER was removed with commit
> 0097422c0dfe0a ("btrfs: remove clone_backref_node() from relocation")

While removing the code is ok, looking to the git history I think
there's probably more, related to the node linking. Here it's removing
one half (LINK_UPPER).