linux-kernel - Re: [PATCH 1/3] dt-bindings: clock: mediatek: Add #reset-cells property for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbd170a3-cbfe-4b4f-a059-efe33fed0e5d@collabora.com>
Date: Thu, 15 May 2025 17:11:13 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Conor Dooley <conor@...nel.org>,
 Julien Massot <julien.massot@...labora.com>
Cc: kernel@...labora.com, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Garmin Chang <garmin.chang@...iatek.com>,
 Friday Yang <friday.yang@...iatek.com>,
 Conor Dooley <conor.dooley@...rochip.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: mediatek: Add #reset-cells
 property for MT8188

Il 15/05/25 17:03, Conor Dooley ha scritto:
> On Thu, May 15, 2025 at 03:31:43PM +0200, Julien Massot wrote:
>> The '#reset-cells' property is required for some of the MT8188
>> clock controllers, but not listed as a valid property.
> 
> "required for some" but not marked required on those platforms.
> Why not?
> 

Yeah now that I read that for the third time, the wording is a bit incorrect.

It's not "required", some clock controllers do have reset controllers, but it
is facultative to actually use the latter.

I'm not sure if the ones that do have reset controllers inside should have the
#reset-cells property as required...

Conor, what do you think?

Cheers,
Angelo

>>
>> Fixes: 9a5cd59640ac ("dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188")
>> Signed-off-by: Julien Massot <julien.massot@...labora.com>
>> ---
>>   Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
>> index 2985c8c717d72888dd49f1f6249a9e2594d8a38d..5403242545ab12a7736ed4fbac26008aa955c724 100644
>> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
>> @@ -52,6 +52,9 @@ properties:
>>     '#clock-cells':
>>       const: 1
>>   
>> +  '#reset-cells':
>> +    const: 1
>> +
>>   required:
>>     - compatible
>>     - reg
>>
>> -- 
>> 2.49.0
>>