linux-kernel - Re: [PATCH v4] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250515175326.67615d3b@jic23-huawei>
Date: Thu, 15 May 2025 17:53:26 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andrew Ijano <andrew.ijano@...il.com>
Cc: andrew.lopes@...mni.usp.br, gustavobastos@....br, David Lechner
 <dlechner@...libre.com>, nuno.sa@...log.com, andy@...nel.org,
 jstephan@...libre.com, linux-iio <linux-iio@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] iio: accel: sca3000: replace usages of internal read
 data helpers by spi helpers

> > >  }
> > > @@ -432,13 +434,13 @@ static int sca3000_print_rev(struct iio_dev *indio_dev)
> > >       struct sca3000_state *st = iio_priv(indio_dev);
> > >
> > >       mutex_lock(&st->lock);  
> >
> > Another patch to use guard(mutex)(&st->lock); etc would be help clean this
> > up by allowing direct return in the error path.  
> 
> Great! In this case, would you suggest the following order?
> 1. One patch for general style changes, like the removal of error_ret labels;
> 2. Another patch for spi changes;
> 3. And another one for using guard(mutex)(&st->lock).

That order is fine.

J