linux-kernel - Re: [PATCH 11/16] iio: mcp3564: Fix type incompatibility with non-macro find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515181405.083dd030@jic23-huawei>
Date: Thu, 15 May 2025 18:14:05 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Alexandru Soponar <asoponar@...adin.ro>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-watchdog@...r.kernel.org, jdelvare@...e.com, linux@...ck-us.net,
 pavel@....cz, lee@...nel.org, baocheng.su@...mens.com,
 wim@...ux-watchdog.org, tobias.schaffner@...mens.com,
 angelogioacchino.delregno@...labora.com, benedikt.niedermayr@...mens.com,
 matthias.bgg@...il.com, aardelean@...libre.com, contact@...y.one
Subject: Re: [PATCH 11/16] iio: mcp3564: Fix type incompatibility with
 non-macro find_closest

On Thu, 15 May 2025 11:13:27 +0300
Alexandru Soponar <asoponar@...adin.ro> wrote:

> The mcp3564_oversampling_avail array was previously declared as unsigned
> int but used with find_closest(). With find_closest() now implemented as
> a function taking signed int parameters instead of a macro,  passing
> unsigned arrays causes type incompatibility errors. This patch changes the
> arrays type from unsigned int to int to ensure compatibility with the
> function signature and prevent compilation errors.
> 
> Signed-off-by: Alexandru Soponar <asoponar@...adin.ro>
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
>  drivers/iio/adc/mcp3564.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index a68f1cd6883e..01efc77f710a 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -253,7 +253,7 @@ enum mcp3564_oversampling {
>  	MCP3564_OVERSAMPLING_RATIO_98304
>  };
>  
> -static const unsigned int mcp3564_oversampling_avail[] = {
> +static const int mcp3564_oversampling_avail[] = {
>  	[MCP3564_OVERSAMPLING_RATIO_32] = 32,
>  	[MCP3564_OVERSAMPLING_RATIO_64] = 64,
>  	[MCP3564_OVERSAMPLING_RATIO_128] = 128,