[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <543ef493-a478-4e92-b384-f6ff299b11fb@kernel.dk>
Date: Thu, 15 May 2025 12:21:34 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Jason Xing <kerneljasonxing@...il.com>, rostedt@...dmis.org,
mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, Jason Xing <kernelxing@...cent.com>,
Yushan Zhou <katrinzhou@...cent.com>
Subject: Re: [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator
in relayfs
On 5/15/25 12:16 AM, Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
>
> Replace internal subbuf_start in blktrace with the default policy
> in relayfs.
>
> Remove dropped field from struct blktrace. Correspondingly, call the
> common helper in relay. Through incrementing full_count to keep track
> of how many times we encountered a full buffer issue, it aids the user
> space app in telling how many lost events appear.
Forgot, I'd rewrite this, "telling how many lost events appear" doesn't
make any sense at all, as these events obviously don't appears in the
first place.
By incrementing full_count to keep track of how many times we
encountered a full buffer issue, user space will know how many events
were lost.
--
Jens Axboe
Powered by blists - more mailing lists