linux-kernel - Re: [PATCH] Input: gpio-keys - Detect long press events in sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44fclxle3b7hfo44ec3vlwlth3uamceaqght3ecu3lmz4eltfz@e57uk7jw3hky>
Date: Thu, 15 May 2025 11:57:58 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: lihua - <lihua@...qin.corp-partner.google.com>, hdegoede@...hat.com, 
	javier.carrasco.cruz@...il.com, zack.rusin@...adcom.com, namcao@...utronix.de, 
	tglx@...utronix.de, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: gpio-keys - Detect long press events in sleep mode

On Mon, May 12, 2025 at 11:50:15AM +0300, Andy Shevchenko wrote:
> On Mon, May 12, 2025 at 03:57:17PM +0800, lihua - wrote:
> 
> First of all, do not top-post!
> 
> > Hello, All linux team members:
> >       Could you please review this modification as soon as possible?
> 
> You even haven't waited for a full week...
> 
> If it's an (important) fix, made it look so (Fixes: tag, Cc: stable@, etc).

I can see that missing input_sync() might hurt, but the patch
description makes no sense. The driver does not really differentiate
between long and sort press.

Please provide a better explanation how missing sync interferes with
your use case.

Thanks.

-- 
Dmitry