[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <097a4926cebc9030469d42cc7a3392b39dfd703d.camel@nvidia.com>
Date: Thu, 15 May 2025 19:06:10 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "jpoimboe@...nel.org" <jpoimboe@...nel.org>
CC: "dakr@...nel.org" <dakr@...nel.org>, "a.hindborg@...nel.org"
<a.hindborg@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
"boqun.feng@...il.com" <boqun.feng@...il.com>, "patches@...ts.linux.dev"
<patches@...ts.linux.dev>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
"tmgross@...ch.edu" <tmgross@...ch.edu>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "alex.gaynor@...il.com"
<alex.gaynor@...il.com>, "benno.lossin@...ton.me" <benno.lossin@...ton.me>,
John Hubbard <jhubbard@...dia.com>, "rust-for-linux@...r.kernel.org"
<rust-for-linux@...r.kernel.org>, "bjorn3_gh@...tonmail.com"
<bjorn3_gh@...tonmail.com>, "peterz@...radead.org" <peterz@...radead.org>,
Joel Fernandes <joelagnelf@...dia.com>, "aliceryhl@...gle.com"
<aliceryhl@...gle.com>, "gary@...yguo.net" <gary@...yguo.net>, Alexandre
Courbot <acourbot@...dia.com>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH 1/5] objtool/rust: add one more `noreturn` Rust function
for Rust 1.87.0
On Thu, 2025-05-15 at 09:18 -0700, Josh Poimboeuf wrote:
> > Since I build with LLVM=1, I'm assuming the answer is 18.1.3
>
> I'm not able to recreate, can you run with OBJTOOL_VERBOSE=1 and paste
> the output?
You probably can't repro because it includes code that hasn't been merged upstream yet. Try this:
https://github.com/ttabi/linux/commits/alex
CHK kernel/kheaders_data.tar.xz
drivers/gpu/nova-core/nova_core.o: warning: objtool:
_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFro
mNtB5_13BiosImageBaseE8try_from() falls through to next function
_RNvMsd_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14FwSecBiosImage12fwsec_header()
drivers/gpu/nova-core/nova_core.o: warning: objtool:
_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFro
mNtB5_13BiosImageBaseE8try_from+0x5c: (branch)
drivers/gpu/nova-core/nova_core.o: warning: objtool:
_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFro
mNtB5_13BiosImageBaseE8try_from+0x4a: (branch)
drivers/gpu/nova-core/nova_core.o: warning: objtool:
_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFro
mNtB5_13BiosImageBaseE8try_from+0x0: <=== (sym)
./tools/objtool/objtool --hacks=jump_label --hacks=noinstr --hacks=skylake --mcount --mnop --
retpoline --rethunk --sls --stackval --static-call --uaccess --prefix=16 --module drivers/gpu/nova-
core/nova_core.o.orig -o drivers/gpu/nova-core/nova_core.o
0000 0000000000006230
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from>:
0000 6230: 55 push %rbp
0001 6231: 48 89 e5 mov %rsp,%rbp
0004 6234: 53 push %rbx
0005 6235: 48 83 ec 18 sub $0x18,%rsp
0009 6239: 48 89 fb mov %rdi,%rbx
000c 623c: 48 8b 3e mov (%rsi),%rdi
000f 623f: 48 8b 4e 10 mov 0x10(%rsi),%rcx
0013 6243: c7 45 f2 ff b8 42 49 movl $0x4942b8ff,-0xe(%rbp)
001a 624a: 66 c7 45 f6 54 00 movw $0x54,-0xa(%rbp)
0020 6250: 48 83 f9 06 cmp $0x6,%rcx
0024 6254: 72 42 jb 6298
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x68>
0026 6256: 48 8d 51 fb lea -0x5(%rcx),%rdx
002a 625a: 31 c0 xor %eax,%eax
002c 625c: 0f 1f 40 00 nopl 0x0(%rax)
0030 6260: 44 8b 04 07 mov (%rdi,%rax,1),%r8d
0034 6264: 44 33 45 f2 xor -0xe(%rbp),%r8d
0038 6268: 44 0f b7 4c 07 04 movzwl 0x4(%rdi,%rax,1),%r9d
003e 626e: 66 44 33 4d f6 xor -0xa(%rbp),%r9w
0043 6273: 45 0f b7 c9 movzwl %r9w,%r9d
0047 6277: 45 09 c1 or %r8d,%r9d
004a 627a: 74 0a je 6286
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x56>
004c 627c: 48 ff c0 inc %rax
004f 627f: 48 39 c2 cmp %rax,%rdx
0052 6282: 75 dc jne 6260
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x30>
0054 6284: eb 12 jmp 6298
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x68>
0056 6286: 48 89 ca mov %rcx,%rdx
0059 6289: 48 29 c2 sub %rax,%rdx
005c 628c: 0f 82 ac 00 00 00 jb 633e
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x10e>
0062 6292: 48 83 fa 0c cmp $0xc,%rdx
0066 6296: 73 30 jae 62c8
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x98>
0068 6298: c7 43 08 ea ff ff ff movl $0xffffffea,0x8(%rbx)
006f 629f: 48 c7 03 02 00 00 00 movq $0x2,(%rbx)
0076 62a6: 48 8b 46 08 mov 0x8(%rsi),%rax
007a 62aa: 48 85 c0 test %rax,%rax
007d 62ad: 48 0f 44 f8 cmove %rax,%rdi
0081 62b1: 31 f6 xor %esi,%esi
0083 62b3: 31 d2 xor %edx,%edx
0085 62b5: e8 00 00 00 00 call 62ba
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x8a> 62b6: R_X86_64_PLT32 rust_helper_krealloc-0x4
008a 62ba: 48 89 d8 mov %rbx,%rax
008d 62bd: 48 83 c4 18 add $0x18,%rsp
0091 62c1: 5b pop %rbx
0092 62c2: 5d pop %rbp
0093 62c3: e9 00 00 00 00 jmp 62c8
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x98> 62c4: R_X86_64_PLT32 __x86_return_thunk-0x4
0098 62c8: 66 81 3c 07 ff b8 cmpw $0xb8ff,(%rdi,%rax,1)
009e 62ce: 75 c8 jne 6298
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x68>
00a0 62d0: 81 7c 07 02 42 49 54 00 cmpl $0x544942,0x2(%rdi,%rax,1)
00a8 62d8: 75 be jne 6298
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x68>
00aa 62da: 0f b6 4c 07 0a movzbl 0xa(%rdi,%rax,1),%ecx
00af 62df: 8b 54 07 06 mov 0x6(%rdi,%rax,1),%edx
00b3 62e3: 44 0f b6 44 07 0b movzbl 0xb(%rdi,%rax,1),%r8d
00b9 62e9: c7 45 ec 42 49 54 00 movl $0x544942,-0x14(%rbp)
00c0 62f0: 66 c7 45 f0 ff b8 movw $0xb8ff,-0x10(%rbp)
00c6 62f6: 48 c1 e1 20 shl $0x20,%rcx
00ca 62fa: 49 c1 e0 28 shl $0x28,%r8
00ce 62fe: 49 09 c8 or %rcx,%r8
00d1 6301: 44 8b 4d ee mov -0x12(%rbp),%r9d
00d5 6305: 48 c7 03 01 00 00 00 movq $0x1,(%rbx)
00dc 630c: 48 89 43 08 mov %rax,0x8(%rbx)
00e0 6310: 48 8d 7b 10 lea 0x10(%rbx),%rdi
00e4 6314: b9 0d 00 00 00 mov $0xd,%ecx
00e9 6319: f3 48 a5 rep movsq %ds:(%rsi),%es:(%rdi)
00ec 631c: c7 43 78 01 00 42 49 movl $0x49420001,0x78(%rbx)
00f3 6323: 44 89 4b 7c mov %r9d,0x7c(%rbx)
00f7 6327: 49 c1 e8 20 shr $0x20,%r8
00fb 632b: 66 44 89 83 84 00 00 00 mov %r8w,0x84(%rbx)
0103 6333: 89 93 80 00 00 00 mov %edx,0x80(%rbx)
0109 6339: e9 7c ff ff ff jmp 62ba
<_RNvXsa_NtCs8S3917Wilyo_9nova_core5vbiosNtB5_14PciAtBiosImageINtNtCsgK88DPai1lC_4core7convert7TryFr
omNtB5_13BiosImageBaseE8try_from+0x8a>
010e 633e: 48 89 c7 mov %rax,%rdi
0111 6341: 48 89 ce mov %rcx,%rsi
0114 6344: 48 c7 c2 00 00 00 00 mov $0x0,%rdx 6347:
R_X86_64_32S .rodata+0x1058
011b 634b: e8 00 00 00 00 call 6350 <.Ltmp38> 634c:
R_X86_64_PLT32 _RNvNtNtCsgK88DPai1lC_4core5slice5index26slice_start_index_len_fail-0x4
Powered by blists - more mailing lists