linux-kernel - Re: [PATCH 2/2] selftests/mm: skip hugevm test if kernel config file is not present.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adcz3xx524ragyywd3uitstcsojpcxe5sqio7ln4rjsgiv2zo2@dcycsbnorcoo>
Date: Thu, 15 May 2025 20:15:10 +0100
From: Pedro Falcato <pfalcato@...e.de>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Zi Yan <ziy@...dia.com>, Adam Sindelar <adam@...signal.io>, 
	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] selftests/mm: skip hugevm test if kernel config file
 is not present.

On Thu, May 15, 2025 at 07:43:40PM +0100, Lorenzo Stoakes wrote:
> On Thu, May 15, 2025 at 02:23:33PM -0400, Zi Yan wrote:
> > When running hugevm tests in a machine without kernel config present, e.g.,
> > a VM running a kernel without CONFIG_IKCONFIG_PROC nor /boot/config-*,
> > skip hugevm tests, which reads kernel config to get page table level
> > information.
> >
> > Signed-off-by: Zi Yan <ziy@...dia.com>
> 
> Looks generally reasonable to me, but I'm not so familiar with this so,
> 
> Acked-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

Acked-by: Pedro Falcato <pfalcato@...e.de>

Same here. Although, despite this being worth patching, I do think we should
document somewhere what the expectations are for mm selftests (in terms of
kernel config, environment, libc, possibly even utilities present).

-- 
Pedro