linux-kernel - Re: [PATCH v1 07/26] x86/cpuid: Introduce debugfs 'x86/scanned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCZW85ZgAyvl0ZCB@lx-t490>
Date: Thu, 15 May 2025 23:04:51 +0200
From: "Ahmed S. Darwish" <darwi@...utronix.de>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	John Ogness <john.ogness@...utronix.de>, x86@...nel.org,
	x86-cpuid@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 07/26] x86/cpuid: Introduce debugfs
 'x86/scanned_cpuid/[0-ncpus]'

Hi Sohil,

On Tue, 13 May 2025, Sohil Mehta wrote:
>
> I tried out the patches.
>

Thanks a lot for giving all of this a test run!

> The debugfs hierarchy mentioned here doesn't match the code.

Indeed.  I've added the extra level "cpus/" folder at a later phase and
forgot updating the changelog.

>
> The code actually builds:
>   x86/scanned_cpuid/cpus/[0-ncpus].
>
> Can we simplify it to below? The "scanned_" part seems unnecessary.
>   x86/cpuid/[0-ncpus]
>
> I would also suggest slight changes to the formatting to make it easier
> to read.
> 1) Indent for the printed register values.
> 2) Move the * to the front of the value to make it more prominent.
>

All the suggestions above are very sensible, so I'll do 'em in v2.

Thanks,
~ Ahmed