linux-kernel - Re: [PATCH v10 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0e6a6cb-3b73-471f-97f8-415fd6ac5333@infradead.org>
Date: Thu, 15 May 2025 14:22:56 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Mario Limonciello <superm1@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Mario Limonciello <mario.limonciello@....com>,
 Perry Yuan <perry.yuan@....com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H . Peter Anvin" <hpa@...or.com>, Jonathan Corbet <corbet@....net>,
 Huang Rui <ray.huang@....com>, "Gautham R . Shenoy"
 <gautham.shenoy@....com>, "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 "open list:AMD HETERO CORE HARDWARE FEEDBACK DRIVER"
 <platform-driver-x86@...r.kernel.org>,
 "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
 <linux-kernel@...r.kernel.org>,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
 "open list:AMD PSTATE DRIVER" <linux-pm@...r.kernel.org>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v10 04/13] platform/x86: hfi: Introduce AMD Hardware
 Feedback Interface Driver

just a coding style nit:

On 5/15/25 2:19 PM, Mario Limonciello wrote:
> diff --git a/drivers/platform/x86/amd/hfi/Kconfig b/drivers/platform/x86/amd/hfi/Kconfig
> new file mode 100644
> index 0000000000000..476e4a9ed67a9
> --- /dev/null
> +++ b/drivers/platform/x86/amd/hfi/Kconfig
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# AMD Hardware Feedback Interface Driver
> +#
> +
> +config AMD_HFI
> +	bool "AMD Hetero Core Hardware Feedback Driver"
> +	depends on ACPI
> +	depends on CPU_SUP_AMD
> +	help
> +	 Select this option to enable the AMD Heterogeneous Core Hardware
> +	 Feedback Interface. If selected, hardware provides runtime thread
> +	 classification guidance to the operating system on the performance and
> +	 energy efficiency capabilities of each heterogeneous CPU core. These
> +	 capabilities may vary due to the inherent differences in the core types
> +	 and can also change as a result of variations in the operating
> +	 conditions of the system such as power and thermal limits.

Help text should be indented with one tab + 2 spaces.

-- 
~Randy