linux-kernel - Re: [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoCLu5PNvfs=_HDfy8NdNj5N1_h5dt4GjVCvB9qSt0EYyg@mail.gmail.com>
Date: Fri, 16 May 2025 07:26:40 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jens Axboe <axboe@...nel.dk>
Cc: rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com, 
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>, Yushan Zhou <katrinzhou@...cent.com>
Subject: Re: [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator
 in relayfs

On Fri, May 16, 2025 at 2:21 AM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 5/15/25 12:16 AM, Jason Xing wrote:
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > Replace internal subbuf_start in blktrace with the default policy
> > in relayfs.
> >
> > Remove dropped field from struct blktrace. Correspondingly, call the
> > common helper in relay. Through incrementing full_count to keep track
> > of how many times we encountered a full buffer issue, it aids the user
> > space app in telling how many lost events appear.
>
> Forgot, I'd rewrite this, "telling how many lost events appear" doesn't
> make any sense at all, as these events obviously don't appears in the
> first place.
>
> By incrementing full_count to keep track of how many times we
> encountered a full buffer issue, user space will know how many events
> were lost.

Oh right, I will adjust it!

Thanks,
Jason

>
> --
> Jens Axboe