linux-kernel - Re: [PATCH v4 00/38] Mediated vPMU 4.0 for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed365c1a-259c-43b4-b08b-9364986968d9@linux.intel.com>
Date: Thu, 15 May 2025 13:45:56 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Sean Christopherson <seanjc@...gle.com>,
 Mingwei Zhang <mizhang@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Paolo Bonzini <pbonzini@...hat.com>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>, Liang@...gle.com,
 Kan <kan.liang@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Yongwei Ma <yongwei.ma@...el.com>,
 Xiong Zhang <xiong.y.zhang@...ux.intel.com>,
 Jim Mattson <jmattson@...gle.com>, Sandipan Das <sandipan.das@....com>,
 Zide Chen <zide.chen@...el.com>, Eranian Stephane <eranian@...gle.com>,
 Shukla Manali <Manali.Shukla@....com>,
 Nikunj Dadhania <nikunj.dadhania@....com>
Subject: Re: [PATCH v4 00/38] Mediated vPMU 4.0 for x86


On 5/15/2025 8:49 AM, Sean Christopherson wrote:
> On Mon, Mar 24, 2025, Mingwei Zhang wrote:
>> Dapeng Mi (18):
>>   KVM: x86/pmu: Introduce enable_mediated_pmu global parameter
>>   KVM: x86/pmu: Check PMU cpuid configuration from user space
>>   KVM: x86: Rename vmx_vmentry/vmexit_ctrl() helpers
>>   KVM: x86/pmu: Add perf_capabilities field in struct kvm_host_values{}
>>   KVM: x86/pmu: Move PMU_CAP_{FW_WRITES,LBR_FMT} into msr-index.h header
>>   KVM: VMX: Add macros to wrap around
>>     {secondary,tertiary}_exec_controls_changebit()
>>   KVM: x86/pmu: Check if mediated vPMU can intercept rdpmc
>>   KVM: x86/pmu/vmx: Save/load guest IA32_PERF_GLOBAL_CTRL with
>>     vm_exit/entry_ctrl
>>   KVM: x86/pmu: Optimize intel/amd_pmu_refresh() helpers
>>   KVM: x86/pmu: Setup PMU MSRs' interception mode
>>   KVM: x86/pmu: Handle PMU MSRs interception and event filtering
>>   KVM: x86/pmu: Switch host/guest PMU context at vm-exit/vm-entry
>>   KVM: x86/pmu: Handle emulated instruction for mediated vPMU
>>   KVM: nVMX: Add macros to simplify nested MSR interception setting
>>   KVM: selftests: Add mediated vPMU supported for pmu tests
>>   KVM: Selftests: Support mediated vPMU for vmx_pmu_caps_test
>>   KVM: Selftests: Fix pmu_counters_test error for mediated vPMU
>>   KVM: x86/pmu: Expose enable_mediated_pmu parameter to user space
>>
>> Kan Liang (8):
>>   perf: Support get/put mediated PMU interfaces
>>   perf: Skip pmu_ctx based on event_type
>>   perf: Clean up perf ctx time
>>   perf: Add a EVENT_GUEST flag
>>   perf: Add generic exclude_guest support
>>   perf: Add switch_guest_ctx() interface
>>   perf/x86: Support switch_guest_ctx interface
>>   perf/x86/intel: Support PERF_PMU_CAP_MEDIATED_VPMU
>>
>> Mingwei Zhang (5):
>>   perf/x86: Forbid PMI handler when guest own PMU
>>   perf/x86/core: Plumb mediated PMU capability from x86_pmu to
>>     x86_pmu_cap
>>   KVM: x86/pmu: Exclude PMU MSRs in vmx_get_passthrough_msr_slot()
>>   KVM: x86/pmu: introduce eventsel_hw to prepare for pmu event filtering
>>   KVM: nVMX: Add nested virtualization support for mediated PMU
>>
>> Sandipan Das (4):
>>   perf/x86/core: Do not set bit width for unavailable counters
>>   KVM: x86/pmu: Add AMD PMU registers to direct access list
>>   KVM: x86/pmu/svm: Set GuestOnly bit and clear HostOnly bit when guest
>>     write to event selectors
>>   perf/x86/amd: Support PERF_PMU_CAP_MEDIATED_VPMU for AMD host
>>
>> Xiong Zhang (3):
>>   x86/irq: Factor out common code for installing kvm irq handler
>>   perf: core/x86: Register a new vector for KVM GUEST PMI
>>   KVM: x86/pmu: Register KVM_GUEST_PMI_VECTOR handler
> I ran out of time today and didn't get emails send for all patches.  I'm planning
> on getting that done tomorrow.
>
> I already have most of the proposed changes implemented:
>
>   https://github.com/sean-jc/linux.git x86/mediated_pmu
>
> It compiles and doesn't explode, but it's not fully functional (PMU tests fail).
> I'll poke at it over the next few days, but if someone is itching to figure out
> what I broke, then by all means.
>
> Given that I've already made many modifications (I have a hard time reviewing a
> series this big without editing as I go), unless someone objects, I'll post v5
> (and v6+ as needed), though that'll like be days/weeks as I need to get it working,
> and want to do more passes over the code, shortlogs, and changelogs. 

Sean, thank you very much for reviewing and refactoring the patchset. I
would look at the code and check it locally in next several days as well.