linux-kernel - Re: [PATCH V2 11/15] csky/perf: Remove driver-specific throttle support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTSKyhzVMeWA9DN7wjaOfKW+K8XiO56c10kim6eesJYDDg@mail.gmail.com>
Date: Thu, 15 May 2025 08:34:53 +0200
From: Guo Ren <guoren@...nel.org>
To: kan.liang@...ux.intel.com
Cc: peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org, 
	irogers@...gle.com, mark.rutland@....com, linux-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, eranian@...gle.com, ctshao@...gle.com, 
	tmricht@...ux.ibm.com, Mao Han <han_mao@...ky.com>, Guo Ren <ren_guo@...ky.com>, 
	linux-csky@...r.kernel.org
Subject: Re: [PATCH V2 11/15] csky/perf: Remove driver-specific throttle support

On Wed, May 14, 2025 at 6:49 PM <kan.liang@...ux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@...ux.intel.com>
>
> The throttle support has been added in the generic code. Remove
> the driver-specific throttle support.
Acked-by: Guo Ren <guoren@...nel.org>

>
> Besides the throttle, perf_event_overflow may return true because of
> event_limit. It already does an inatomic event disable. The pmu->stop
> is not required either.
>
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Mao Han <han_mao@...ky.com>
> Cc: Guo Ren <ren_guo@...ky.com>
> Cc: linux-csky@...r.kernel.org
> ---
>  arch/csky/kernel/perf_event.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/csky/kernel/perf_event.c b/arch/csky/kernel/perf_event.c
> index e5f18420ce64..e0a36acd265b 100644
> --- a/arch/csky/kernel/perf_event.c
> +++ b/arch/csky/kernel/perf_event.c
> @@ -1139,8 +1139,7 @@ static irqreturn_t csky_pmu_handle_irq(int irq_num, void *dev)
>                 perf_sample_data_init(&data, 0, hwc->last_period);
>                 csky_pmu_event_set_period(event);
>
> -               if (perf_event_overflow(event, &data, regs))
> -                       csky_pmu_stop_event(event);
> +               perf_event_overflow(event, &data, regs);
>         }
>
>         csky_pmu_enable(&csky_pmu.pmu);
> --
> 2.38.1
>
>


-- 
Best Regards
 Guo Ren