linux-kernel - Re: [PATCH v3] rust: regulator: add a bare minimum regulator abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCWjox6uWXVgcZ6v@finisterre.sirena.org.uk>
Date: Thu, 15 May 2025 10:19:47 +0200
From: Mark Brown <broonie@...nel.org>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Benno Lossin <lossin@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v3] rust: regulator: add a bare minimum regulator
 abstraction

On Wed, May 14, 2025 at 01:10:52PM -0300, Daniel Almeida wrote:
> > On 14 May 2025, at 12:50, Mark Brown <broonie@...nel.org> wrote:

> >> Hmm, so a `struct regulator` might already be enabled and calling
> >> `regulator_enable` doesn't do anything?

> > It takes a reference to the regulator.  This may or may not result in a
> > change in an underlying physical regulator.

> I assume these are two different reference counts, right? One for
> regulator_get()/regulator_put(), and one for
> regulator_enable()/regulator_disable().

> Looking at regulator_dev, I can see both "use_count" and "open_count" for
> example.

Yes, there are separate counts for gets and enables.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)