linux-kernel - RE: [PATCH 1/1] iommu/vt-d: Restore context entry setup order for aliased devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276F8DB389BF90F9EF97C418C90A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Thu, 15 May 2025 08:28:53 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Will
 Deacon" <will@...nel.org>, Robin Murphy <robin.murphy@....com>, Aditya Garg
	<gargaditya08@...e.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
	kobarity <kobarity@...il.com>
CC: "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] iommu/vt-d: Restore context entry setup order for
 aliased devices

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Wednesday, May 14, 2025 2:05 PM
> 
> Commit 2031c469f816 ("iommu/vt-d: Add support for static identity domain")
> changed the context entry setup during domain attachment from a
> set-and-check policy to a clear-and-reset approach. This inadvertently
> introduced a regression affecting PCI aliased devices behind PCIe-to-PCI
> bridges.
> 
> Specifically, keyboard and touchpad stopped working on several Apple
> Macbooks with below messages:
> 
>  kernel: platform pxa2xx-spi.3: Adding to iommu group 20
>  kernel: input: Apple SPI Keyboard as
>  /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-
> APP000D:00/input/input0
>  kernel: DMAR: DRHD: handling fault status reg 3
>  kernel: DMAR: [DMA Read NO_PASID] Request device [00:1e.3] fault addr
>  0xffffa000 [fault reason 0x06] PTE Read access is not set
>  kernel: DMAR: DRHD: handling fault status reg 3
>  kernel: DMAR: [DMA Read NO_PASID] Request device [00:1e.3] fault addr
>  0xffffa000 [fault reason 0x06] PTE Read access is not set
>  kernel: applespi spi-APP000D:00: Error writing to device: 01 0e 00 00
>  kernel: DMAR: DRHD: handling fault status reg 3
>  kernel: DMAR: [DMA Read NO_PASID] Request device [00:1e.3] fault addr
>  0xffffa000 [fault reason 0x06] PTE Read access is not set
>  kernel: DMAR: DRHD: handling fault status reg 3
>  kernel: applespi spi-APP000D:00: Error writing to device: 01 0e 00 00
> 
> Fix this by restoring the previous context setup order.
> 
> Fixes: 2031c469f816 ("iommu/vt-d: Add support for static identity domain")
> Closes: https://lore.kernel.org/all/4dada48a-c5dd-4c30-9c85-
> 5b03b0aa01f0@....ch/
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>