linux-kernel - Re: [PATCH v11 17/30] x86/resctrl: Move enum resctrl_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bb359bd-c534-4947-8eb1-6231d6b062f1@nvidia.com>
Date: Wed, 14 May 2025 18:00:01 -0700
From: Fenghua Yu <fenghuay@...dia.com>
To: James Morse <james.morse@....com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Reinette Chatre <reinette.chatre@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH v11 17/30] x86/resctrl: Move enum resctrl_event_id to
 resctrl.h


On 5/13/25 10:15, James Morse wrote:
> resctrl_types.h contains common types and constants to enable architectures
> to use these types in their definitions within asm/resctrl.h
>
> enum resctrl_event_id was placed in resctrl_types.h for
> resctrl_arch_get_cdp_enabled() and resctrl_arch_set_cdp_enabled(), but
> these two functions are no longer inlined by any architecture.
>
> Move enum resctrl_event_id to resctrl.h
>
> Signed-off-by: James Morse <james.morse@....com>
> Tested-by: Babu Moger <babu.moger@....com>
> Tested-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reviewed-by: Fenghua Yu <fenghuay@...dia.com>

Thanks.

-Fenghua

> ---
> Changes since v9:
>   * Replaced commit message with Reinette's version.
>
> Changes since v8:
>   * This patch is new.
> ---
>   include/linux/resctrl.h       | 10 ++++++++++
>   include/linux/resctrl_types.h | 10 ----------
>   2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index b9d1f2916e9c..5ef972cbf56b 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -48,6 +48,16 @@ int proc_resctrl_show(struct seq_file *m,
>   	for_each_rdt_resource((r))					      \
>   		if ((r)->mon_capable)
>   
> +enum resctrl_res_level {
> +	RDT_RESOURCE_L3,
> +	RDT_RESOURCE_L2,
> +	RDT_RESOURCE_MBA,
> +	RDT_RESOURCE_SMBA,
> +
> +	/* Must be the last */
> +	RDT_NUM_RESOURCES,
> +};
> +
>   /**
>    * enum resctrl_conf_type - The type of configuration.
>    * @CDP_NONE:	No prioritisation, both code and data are controlled or monitored.
> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
> index a66e7936943e..a25fb9c4070d 100644
> --- a/include/linux/resctrl_types.h
> +++ b/include/linux/resctrl_types.h
> @@ -34,16 +34,6 @@
>   /* Max event bits supported */
>   #define MAX_EVT_CONFIG_BITS		GENMASK(6, 0)
>   
> -enum resctrl_res_level {
> -	RDT_RESOURCE_L3,
> -	RDT_RESOURCE_L2,
> -	RDT_RESOURCE_MBA,
> -	RDT_RESOURCE_SMBA,
> -
> -	/* Must be the last */
> -	RDT_NUM_RESOURCES,
> -};
> -
>   /*
>    * Event IDs, the values match those used to program IA32_QM_EVTSEL before
>    * reading IA32_QM_CTR on RDT systems.