linux-kernel - Re: [PATCH v6 8/9] blk-mq: use hk cpus only when isolcpus=io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c162a99-05f5-408c-b513-4005690d56a2@flourine.local>
Date: Thu, 15 May 2025 10:36:40 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Ming Lei <ming.lei@...hat.com>
Cc: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
	Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	"Michael S. Tsirkin" <mst@...hat.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Costa Shulyupin <costa.shul@...hat.com>, 
	Juri Lelli <juri.lelli@...hat.com>, Valentin Schneider <vschneid@...hat.com>, 
	Waiman Long <llong@...hat.com>, Frederic Weisbecker <frederic@...nel.org>, 
	Mel Gorman <mgorman@...e.de>, Hannes Reinecke <hare@...e.de>, 
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org, linux-block@...r.kernel.org, 
	linux-nvme@...ts.infradead.org, megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org, 
	storagedev@...rochip.com, virtualization@...ts.linux.dev, 
	GR-QLogic-Storage-Upstream@...vell.com
Subject: Re: [PATCH v6 8/9] blk-mq: use hk cpus only when isolcpus=io_queue
 is enabled

On Fri, May 09, 2025 at 10:38:32AM +0800, Ming Lei wrote:
> > +static bool blk_mq_map_hk_queues(struct blk_mq_queue_map *qmap)
> > +{
> > +	struct cpumask *hk_masks;
> > +	cpumask_var_t isol_mask;
> > +	unsigned int queue, cpu, nr_masks;
> > +
> > +	if (!housekeeping_enabled(HK_TYPE_IO_QUEUE))
> > +		return false;
> 
> It could be more readable to move the above check to the caller.

I wanted to avoid checking if housekeeping is enabled twice in a row.
I'll post the next version with your suggestion and see if this approach
is better.