linux-kernel - Re: [PATCH V2 2/2] mmc: sdhci-msm: Enable force hw reset during cqe recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2frduref6loba4knl73aryr3a4kdtuohm3m74tdkrv2tl7oxqp@clyp2bkqfr5t>
Date: Thu, 15 May 2025 11:53:54 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Sarthak Garg <quic_sartgarg@...cinc.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        quic_cang@...cinc.com, quic_nguyenb@...cinc.com,
        quic_rampraka@...cinc.com, quic_pragalla@...cinc.com,
        quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
        quic_bhaskarv@...cinc.com
Subject: Re: [PATCH V2 2/2] mmc: sdhci-msm: Enable force hw reset during cqe
 recovery

On Wed, May 14, 2025 at 04:41:55PM +0530, Sarthak Garg wrote:
> Enable force hw reset during cqe recovery to make recovery more robust.

Nit: CQE

What happens without a reset? Is this only required for certain
platforms or does it apply to all MSM platforms? What are the
consequences of a reset?

> 
> Signed-off-by: Sarthak Garg <quic_sartgarg@...cinc.com>
> Acked-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  drivers/mmc/host/sdhci-msm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 66c0d1ba2a33..711252ad24a9 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -2730,6 +2730,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)
>  
>  	msm_host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_NEED_RSP_BUSY;
>  
> +	/* Enable force hw reset during cqe recovery */
> +	msm_host->mmc->cqe_recovery_reset_always = true;
> +
>  	/* Set the timeout value to max possible */
>  	host->max_timeout_count = 0xF;
>  
> -- 
> 2.17.1
> 

-- 
With best wishes
Dmitry