linux-kernel - Re: [PATCH 2/9] arm64: dts: imx8mn-bsh-smm-s2-common: Leave regulator under hw state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db3f6178-646b-4f42-983e-9004d61dabc2@gmail.com>
Date: Thu, 15 May 2025 11:54:17 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: Simon Holesch <simon.holesch@...g.com>,
 Karthikdatt Anantharamrao <karthikdatt.anantharamrao@...bosch.com>,
 michael@...rulasolutions.com, linux-amarula@...rulasolutions.com,
 Wolfgang Birkner <wolfgang.birkner@...g.com>,
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/9] arm64: dts: imx8mn-bsh-smm-s2-common: Leave regulator
 under hw state machine

On 14/05/2025 11:24, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@...rulasolutions.com>
> 
> Let regulator to be controlled by hardware state machine.

Is it possible to add a note _why_ these regulators must be controlled 
by the state machine and not by the software?

> 
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> ---
> 
>   arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> index 5a1ec2f6a552..0d343ffdb7f9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
> @@ -144,6 +144,7 @@ buck4_reg: BUCK4 {
>   				regulator-max-microvolt = <3300000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			buck5_reg: BUCK5 {
> @@ -153,6 +154,7 @@ buck5_reg: BUCK5 {
>   				regulator-max-microvolt = <1995000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			buck6_reg: BUCK6 {
> @@ -162,6 +164,7 @@ buck6_reg: BUCK6 {
>   				regulator-max-microvolt = <1400000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				rohm,no-regulator-enable-control;
>   			};
>   
>   			ldo1_reg: LDO1 {

Yours,
	-- Matti