linux-kernel - Re: 回复: [PATCH] hfs: export dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a8e52d5019df1af7fd99dcf42467ece28b5c858.camel@dubeyko.com>
Date: Wed, 14 May 2025 18:22:57 -0700
From: Viacheslav Dubeyko <slava@...eyko.com>
To: 李扬韬 <frank.li@...o.com>, 
 "glaubitz@...sik.fu-berlin.de"
	 <glaubitz@...sik.fu-berlin.de>
Cc: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, 
 "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH] hfs: export dbg_flags
 in debugfs

On Sun, 2025-05-11 at 10:45 +0000, 李扬韬 wrote:
> Hi Slava,
> 
> > Frankly speaking, if we would like to rework the debugging
> > framework in HFS/HFS+, then I prefer to switch on pr_debug() and to
> > use dynamic debug framework of Linux kernel [1]. It will provide
> > the more flexible solution.
> 
> I'll try it.

Sounds good! As far as I can see, it should be pretty simple fix. And I
think we we need to unify the code for HFS and HFS+. I am considering
to introduce HFS folder in include/linux where we can gather small
duplicated code patterns of HFS/HFS+. However, for more complex
duplicated code patterns, maybe, we need to consider of introduction an
fs/hfs_common module or shared HFS subsystem.

> 
> By the way, I plan to export disk, mem and some statistics related
> information to debugfs, just like f2fs does. Any suggestions?
> 

I think there is no troubles with it. But could you please share which
particular stats would you like to keep in debugfs? Which in-core and
on-disk objects fields will be stored into debugfs?

Thanks,
Slava.