linux-kernel - Re: [PATCH] selftests/mm: Deduplicate test logging in test_mlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1481870-56b1-48b0-b484-22eeb3b5ccf2@arm.com>
Date: Thu, 15 May 2025 15:00:58 +0530
From: Dev Jain <dev.jain@....com>
To: Mark Brown <broonie@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/mm: Deduplicate test logging in
 test_mlock_lock()



On 15/05/25 2:57 pm, Mark Brown wrote:
> The mlock2-tests test_mlock_lock() test reports two test results with
> an identical string, one reporitng if it successfully locked a block of
> memory and another reporting if the lock is still present after doing an
> unlock (following a similar pattern to other tests in the same program).
> This confuses test automation since the test string is used to deduplicate
> tests, change the post unlock test to report "Unlocked" instead like the
> other tests to fix this.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>   tools/testing/selftests/mm/mlock2-tests.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/mlock2-tests.c b/tools/testing/selftests/mm/mlock2-tests.c
> index 7f0d50fa361d..3e90ff37e336 100644
> --- a/tools/testing/selftests/mm/mlock2-tests.c
> +++ b/tools/testing/selftests/mm/mlock2-tests.c
> @@ -196,7 +196,7 @@ static void test_mlock_lock(void)
>   		ksft_exit_fail_msg("munlock(): %s\n", strerror(errno));
>   	}
>   
> -	ksft_test_result(!unlock_lock_check(map), "%s: Locked\n", __func__);
> +	ksft_test_result(!unlock_lock_check(map), "%s: Unlocked\n", __func__);
>   	munmap(map, 2 * page_size);
>   }
>   

Acked-by: Dev Jain <dev.jain@....com>

> 
> ---
> base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3
> change-id: 20250514-selftest-mm-mlock2-dup-277d586bb29d
> 
> Best regards,