linux-kernel - Re: [PATCH 11/28] mm, swap: clean up and consolidate helper for mTHP swapin check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMgjq7AuyTCRymHA3wZ6hp7ui9_LrwM4jq0cyAkqGjgG39erOw@mail.gmail.com>
Date: Thu, 15 May 2025 17:39:48 +0800
From: Kairui Song <ryncsn@...il.com>
To: Klara Modin <klarasmodin@...il.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, 
	Matthew Wilcox <willy@...radead.org>, Hugh Dickins <hughd@...gle.com>, Chris Li <chrisl@...nel.org>, 
	David Hildenbrand <david@...hat.com>, Yosry Ahmed <yosryahmed@...gle.com>, 
	"Huang, Ying" <ying.huang@...ux.alibaba.com>, Nhat Pham <nphamcs@...il.com>, 
	Johannes Weiner <hannes@...xchg.org>, Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	Baoquan He <bhe@...hat.com>, Barry Song <baohua@...nel.org>, 
	Kalesh Singh <kaleshsingh@...gle.com>, Kemeng Shi <shikemeng@...weicloud.com>, 
	Tim Chen <tim.c.chen@...ux.intel.com>, Ryan Roberts <ryan.roberts@....com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/28] mm, swap: clean up and consolidate helper for mTHP
 swapin check

On Thu, May 15, 2025 at 5:31 PM Klara Modin <klarasmodin@...il.com> wrote:
>
> Hi,
>
> On 2025-05-15 04:17:11 +0800, Kairui Song wrote:
> > From: Kairui Song <kasong@...cent.com>
> >
> > Move all mTHP swapin check into can_swapin_thp and use it for both pre
> > IO check and post IO check. This way the code is more consolidated and
> > make later commit easier to maintain.
>
> From what I can see, can_swapin_thp is gated behind
> CONFIG_TRANSPARENT_HUGEPAGE and this fails to build when it's not
> enabled.

Thanks for the review.

Right, I might have to add an empty one for
!CONFIG_TRANSPARENT_HUGEPAGE to pass the build.