linux-kernel - Re: [PATCH] selftests/mm: Fix test result reporting in gup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5554b6e-0db0-4f34-b42a-b0b0b9a047bc@arm.com>
Date: Thu, 15 May 2025 15:13:40 +0530
From: Dev Jain <dev.jain@....com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
 linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm



On 15/05/25 3:11 pm, Mark Brown wrote:
> On Thu, May 15, 2025 at 03:05:07PM +0530, Dev Jain wrote:
>> On 15/05/25 2:27 pm, Mark Brown wrote:
> 
>>> @@ -189,7 +214,10 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared)
>>>    		 * some previously unsupported filesystems, we might want to
>>>    		 * perform some additional tests for possible data corruptions.
>>>    		 */
>>> -		ksft_test_result(should_work, "Should have worked\n");
>>> +		if (should_work)
>>> +			result = KSFT_PASS;
> 
>> Missed printing "Should have worked" here.
> 
> I didn't think that output was particularly useful separate to the
> overall test result (which is logged on exit from the function), it's
> just the test result more than diagnostic information.

No hard opinion.

> 
> Please delete unneeded context from mails when replying.  Doing this
> makes it much easier to find your reply in the message, helping ensure
> it won't be missed by people scrolling through the irrelevant quoted
> material.

You have mentioned that before, sorry my bad! I also hate it :)