[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA+D8APSQK8FqGYYmAygF-dhM7N_54Zw-jSz4xWrr5ToGfUKmw@mail.gmail.com>
Date: Thu, 15 May 2025 18:23:26 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Daniel Baluta <daniel.baluta@...il.com>
Cc: Shengjiu Wang <shengjiu.wang@....com>, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, carlos.song@....com
Subject: Re: [PATCH 1/6] arm64: dts: imx94: Add micfil and mqs device nodes
On Thu, May 15, 2025 at 6:19 PM Daniel Baluta <daniel.baluta@...il.com> wrote:
>
> On Thu, May 15, 2025 at 8:21 AM Shengjiu Wang <shengjiu.wang@....com> wrote:
> >
> > Add micfil and mqs device nodes
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > ---
> > arch/arm64/boot/dts/freescale/imx94.dtsi | 30 ++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx94.dtsi b/arch/arm64/boot/dts/freescale/imx94.dtsi
> > index 3661ea48d7d2..77297dde5c95 100644
> > --- a/arch/arm64/boot/dts/freescale/imx94.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx94.dtsi
> > @@ -108,6 +108,16 @@ scmi_misc: protocol@84 {
> > };
> > };
> >
> > + mqs1: mqs1 {
> > + compatible = "fsl,imx943-aonmix-mqs";
> > + status = "disabled";
> > + };
> > +
> > + mqs2: mqs2 {
> > + compatible = "fsl,imx943-wakeupmix-mqs";
> > + status = "disabled";
> > + };
>
> Node names should be somehow generic.
>
> So here, we need to have something like:
>
> mqs1: mqs@<ip_addr>
>
> similar for mqs2.
There is no ip address for mqs module. The only control register is
in BLK_CTRL.
best regards
Shengjiu Wang
Powered by blists - more mailing lists