linux-kernel - Re: [PATCH v12 4/4] usb: host: enable USB offload during system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOuDEK1uRyxHo90TUTyyVVV3W+ubkmyGvehxTdZ6NRg8LWbXbA@mail.gmail.com>
Date: Thu, 15 May 2025 18:37:00 +0800
From: Guan-Yu Lin <guanyulin@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: mathias.nyman@...el.com, stern@...land.harvard.edu, sumit.garg@...nel.org, 
	gargaditya08@...e.com, kekrby@...il.com, jeff.johnson@....qualcomm.com, 
	quic_zijuhu@...cinc.com, andriy.shevchenko@...ux.intel.com, 
	ben@...adent.org.uk, broonie@...nel.org, quic_wcheng@...cinc.com, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 4/4] usb: host: enable USB offload during system sleep

On Fri, Apr 25, 2025 at 7:15 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, Apr 16, 2025 at 02:43:04PM +0000, Guan-Yu Lin wrote:
> > @@ -724,6 +725,8 @@ struct usb_device {
> >       unsigned do_remote_wakeup:1;
> >       unsigned reset_resume:1;
> >       unsigned port_is_suspended:1;
> > +     unsigned offload_at_suspend:1;
> > +     int offload_usage;
>
> Why is this moved now?  Why isn't it in the proper place from the
> beginning?
>
> thanks,
>
> greg k-h

Thanks for spotting this. Let me address it in the next patch.

Regards,
Guan-Yu