linux-kernel - Re: [PATCH v7 14/14] arm64: dts: rockchip: enable vicap dvp on wolfvision pf5 io expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b7b54c6-568a-4534-960e-33269adbaee1@wolfvision.net>
Date: Thu, 15 May 2025 13:45:35 +0200
From: Gerald Loacker <gerald.loacker@...fvision.net>
To: michael.riesch@...labora.com, Mehdi Djait <mehdi.djait@...ux.intel.com>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Théo Lebrun <theo.lebrun@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Markus Elfring <Markus.Elfring@....de>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Kever Yang <kever.yang@...k-chips.com>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Collabora Kernel Team <kernel@...labora.com>,
 Paul Kocialkowski <paulk@...-base.io>,
 Alexander Shiyan <eagle.alexander923@...il.com>,
 Val Packett <val@...kett.cool>, Rob Herring <robh@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org,
 Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCH v7 14/14] arm64: dts: rockchip: enable vicap dvp on
 wolfvision pf5 io expander

Hi Michael,

Am 14.05.2025 um 17:41 schrieb Michael Riesch via B4 Relay:
> From: Michael Riesch <michael.riesch@...fvision.net>
> 
> The Digital Video Port (DVP, the 16-bit variant) of the RK3568 VICAP
> is broken out to the PF5 mainboard expansion header.
> Enable it in the device tree overlay for the WolfVision PF5 IO
> Expander board.
> 
> Signed-off-by: Michael Riesch <michael.riesch@...fvision.net>
> Signed-off-by: Michael Riesch <michael.riesch@...labora.com>
> ---
>  .../rockchip/rk3568-wolfvision-pf5-io-expander.dtso  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> index 048933de2943..8cfce71dd318 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/clock/rk3568-cru.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/media/video-interfaces.h>
>  #include <dt-bindings/pinctrl/rockchip.h>
>  
>  &{/} {
> @@ -134,3 +135,22 @@ &usb2phy0_host {
>  	phy-supply = <&usb_host_vbus>;
>  	status = "okay";
>  };
> +
> +&vicap {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&cif_clk &cif_dvp_clk &cif_dvp_bus16>;
> +	status = "okay";
> +};
> +
> +&vicap_dvp {
> +	vicap_dvp_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_BT656>;
> +		bus-width = <16>;
> +		pclk-sample = <MEDIA_PCLK_SAMPLE_DUAL_EDGE>;
> +		rockchip,dvp-clk-delay = <10>;
> +	};
> +};
> +
> +&vicap_mmu {
> +	status = "okay";
> +};
> 

Reviewed-by: Gerald Loacker <gerald.loacker@...fvision.net>
Tested-by: Gerald Loacker <gerald.loacker@...fvision.net>

Regards,
Gerald