linux-kernel - Re: [PATCH] platform/x86: dell-wmi-sysman: Avoid buffer overflow in current_password

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174730994725.2473.3936667480812297322.b4-ty@linux.intel.com>
Date: Thu, 15 May 2025 14:52:27 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Prasanth Ksr <prasanth.ksr@...l.com>, 
 Vladimir Moskovkin <Vladimir.Moskovkin@...persky.com>
Cc: Hans de Goede <hdegoede@...hat.com>, 
 Mario Limonciello <mario.limonciello@...l.com>, 
 Divya Bharathi <divya.bharathi@...l.com>, Dell.Client.Kernel@...l.com, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 stable@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: Avoid buffer overflow
 in current_password_store()

On Wed, 14 May 2025 12:12:55 +0000, Vladimir Moskovkin wrote:

> If the 'buf' array received from the user contains an empty string, the
> 'length' variable will be zero. Accessing the 'buf' array element with
> index 'length - 1' will result in a buffer overflow.
> 
> Add a check for an empty string.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-wmi-sysman: Avoid buffer overflow in current_password_store()
      commit: 4e89a4077490f52cde652d17e32519b666abf3a6

--
 i.