linux-kernel - Re: [RFC PATCH v2 16/51] mm: hugetlb: Consolidate interpretation of gbl_chg within alloc_hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCVMxRRTz1d_QyUA@casper.infradead.org>
Date: Thu, 15 May 2025 03:09:09 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Ackerley Tng <ackerleytng@...gle.com>
Cc: kvm@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, linux-fsdevel@...r.kernel.org, aik@....com,
	ajones@...tanamicro.com, akpm@...ux-foundation.org,
	amoorthy@...gle.com, anthony.yznaga@...cle.com, anup@...infault.org,
	aou@...s.berkeley.edu, bfoster@...hat.com,
	binbin.wu@...ux.intel.com, brauner@...nel.org,
	catalin.marinas@....com, chao.p.peng@...el.com,
	chenhuacai@...nel.org, dave.hansen@...el.com, david@...hat.com,
	dmatlack@...gle.com, dwmw@...zon.co.uk, erdemaktas@...gle.com,
	fan.du@...el.com, fvdl@...gle.com, graf@...zon.com,
	haibo1.xu@...el.com, hch@...radead.org, hughd@...gle.com,
	ira.weiny@...el.com, isaku.yamahata@...el.com, jack@...e.cz,
	james.morse@....com, jarkko@...nel.org, jgg@...pe.ca,
	jgowans@...zon.com, jhubbard@...dia.com, jroedel@...e.de,
	jthoughton@...gle.com, jun.miao@...el.com, kai.huang@...el.com,
	keirf@...gle.com, kent.overstreet@...ux.dev,
	kirill.shutemov@...el.com, liam.merwick@...cle.com,
	maciej.wieczor-retman@...el.com, mail@...iej.szmigiero.name,
	maz@...nel.org, mic@...ikod.net, michael.roth@....com,
	mpe@...erman.id.au, muchun.song@...ux.dev, nikunj@....com,
	nsaenz@...zon.es, oliver.upton@...ux.dev, palmer@...belt.com,
	pankaj.gupta@....com, paul.walmsley@...ive.com, pbonzini@...hat.com,
	pdurrant@...zon.co.uk, peterx@...hat.com, pgonda@...gle.com,
	pvorel@...e.cz, qperret@...gle.com, quic_cvanscha@...cinc.com,
	quic_eberman@...cinc.com, quic_mnalajal@...cinc.com,
	quic_pderrin@...cinc.com, quic_pheragu@...cinc.com,
	quic_svaddagi@...cinc.com, quic_tsoni@...cinc.com,
	richard.weiyang@...il.com, rick.p.edgecombe@...el.com,
	rientjes@...gle.com, roypat@...zon.co.uk, rppt@...nel.org,
	seanjc@...gle.com, shuah@...nel.org, steven.price@....com,
	steven.sistare@...cle.com, suzuki.poulose@....com, tabba@...gle.com,
	thomas.lendacky@....com, usama.arif@...edance.com,
	vannapurve@...gle.com, vbabka@...e.cz, viro@...iv.linux.org.uk,
	vkuznets@...hat.com, wei.w.wang@...el.com, will@...nel.org,
	xiaoyao.li@...el.com, yan.y.zhao@...el.com, yilun.xu@...el.com,
	yuzenghui@...wei.com, zhiquan1.li@...el.com
Subject: Re: [RFC PATCH v2 16/51] mm: hugetlb: Consolidate interpretation of
 gbl_chg within alloc_hugetlb_folio()

On Wed, May 14, 2025 at 04:41:55PM -0700, Ackerley Tng wrote:
> -static struct folio *dequeue_hugetlb_folio_vma(struct hstate *h,
> -				struct vm_area_struct *vma,
> -				unsigned long address, long gbl_chg)
> +static struct folio *dequeue_hugetlb_folio(struct hstate *h,
> +					   struct vm_area_struct *vma,
> +					   unsigned long address)

Pleaase don't mess with the indentation unless necessary.  Nobody
cares what your personal style preference is.  You're obscuring the
actual changes.