linux-kernel - Re: [PATCH] fuse: dev: avoid a build warning when PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC1kPDOOxsruVdFRQW0t53R6Xcn2bbaTm1ZLbuSfVTDADVNEJQ@mail.gmail.com>
Date: Thu, 15 May 2025 10:10:47 +0800
From: Chen Linxuan <chenlinxuan@...ontech.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Miklos Szeredi <miklos@...redi.hu>, 
	Miklos Szeredi <mszeredi@...hat.com>, linux-fsdevel@...r.kernel.org, 
	Chen Linxuan <chenlinxuan@...ontech.com>
Subject: Re: [PATCH] fuse: dev: avoid a build warning when PROC_FS is not set

Reviewed-by: Chen Linxuan <chenlinxuan@...ontech.com>

On Thu, May 15, 2025 at 5:42 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Fix a build warning when CONFIG_PROC_FS is not set by surrounding the
> function with #ifdef CONFIG_PROC_FS.
>
> fs/fuse/dev.c:2620:13: warning: 'fuse_dev_show_fdinfo' defined but not used [-Wunused-function]
>  2620 | static void fuse_dev_show_fdinfo(struct seq_file *seq, struct file *file)
>
> Fixes: 514d9210bf45 ("fs: fuse: add dev id to /dev/fuse fdinfo")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Miklos Szeredi <miklos@...redi.hu>
> Cc: Miklos Szeredi <mszeredi@...hat.com>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: Chen Linxuan <chenlinxuan@...ontech.com>
> ---
>  fs/fuse/dev.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-next-20250514.orig/fs/fuse/dev.c
> +++ linux-next-20250514/fs/fuse/dev.c
> @@ -2617,6 +2617,7 @@ static long fuse_dev_ioctl(struct file *
>         }
>  }
>
> +#ifdef CONFIG_PROC_FS
>  static void fuse_dev_show_fdinfo(struct seq_file *seq, struct file *file)
>  {
>         struct fuse_dev *fud = fuse_get_dev(file);
> @@ -2625,6 +2626,7 @@ static void fuse_dev_show_fdinfo(struct
>
>         seq_printf(seq, "fuse_connection:\t%u\n", fud->fc->dev);
>  }
> +#endif
>
>  const struct file_operations fuse_dev_operations = {
>         .owner          = THIS_MODULE,
>
>