linux-kernel - Re: [net-next v1] net: wwan: t7xx: Parameterize data plane RX BAT and FAG count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516084320.66998caf@kernel.org>
Date: Fri, 16 May 2025 08:43:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jinjian Song <jinjian.song@...ocom.com>
Cc: andrew+netdev@...n.ch, angelogioacchino.delregno@...labora.com,
 chandrashekar.devegowda@...el.com, chiranjeevi.rapolu@...ux.intel.com,
 corbet@....net, danielwinkler@...gle.com, davem@...emloft.net,
 edumazet@...gle.com, haijun.liu@...iatek.com, helgaas@...nel.org,
 horms@...nel.org, johannes@...solutions.net, korneld@...gle.com,
 linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 loic.poulain@...aro.org, m.chetan.kumar@...ux.intel.com,
 matthias.bgg@...il.com, netdev@...r.kernel.org, pabeni@...hat.com,
 rafael.wang@...ocom.com, ricardo.martinez@...ux.intel.com,
 ryazanov.s.a@...il.com
Subject: Re: [net-next v1] net: wwan: t7xx: Parameterize data plane RX BAT
 and FAG count

On Fri, 16 May 2025 11:46:57 +0800 Jinjian Song wrote:
> >Module parameters are discouraged, they are pretty poor as an API since
> >they apply to all devices in the system. Can you describe what "frg"
> >and "bat" are ? One of the existing APIs likely covers them.
> >Please also describe the scope (are they per netdev or some sort of
> >device level params)?  
> 
> MTK t7xx data plane hardware use BAT (Buffer Address Table) and FRG (Fragment) BAT
> to describle and manager RX buffer, these buffers will apply for a fixed size after
> the driver probe, and accompany the life cycle of the driver.
> 
> On some platforms, especially those that use swiotlb to manager buffers, without
> changing the buffer pool provided by swiotlb, it's needed to adjust the buffers
> used by the driver to meet the requirements.
> So parameterize these buffers applicable to the MTK t7xx driver to facilitate
> different platforms to work with different configurations. 

Have you looked at
https://docs.kernel.org/networking/ethtool-netlink.html#rings-set 
?