linux-kernel - Re: [PATCH v3] erofs: support deflate decompress by using Intel QAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516163857.GA1241@sol>
Date: Fri, 16 May 2025 09:38:57 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Bo Liu <liubo03@...pur.com>
Cc: xiang@...nel.org, chao@...nel.org, linux-erofs@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] erofs: support deflate decompress by using Intel QAT

On Fri, May 16, 2025 at 04:26:34AM -0400, Bo Liu wrote:
> +config EROFS_FS_ZIP_CRYPTO
> +	bool "EROFS hardware decompression support (crypto interface)"
> +	depends on EROFS_FS_ZIP
> +	help
> +	  Saying Y here includes support for reading EROFS file systems
> +	  containing crypto compressed data.  It gives better decompression
> +	  speed than the software-implemented compression, and it costs
> +	  lower CPU overhead.
> +
> +	  Crypto support is an experimental feature for now and so most
> +	  file systems will be readable without selecting this option.
> +
> +	  If unsure, say N.

I recommend not including the word "crypto" in any user facing part of this.

Compression algorithms are not cryptographic algorithms.  The fact that the
interface to access hardware compression accelerators is currently the "Crypto
API" is an implementation quirk.  It could be a different interface in the
future.

Call it something clear like "hardware decompression".

- Eric