linux-kernel - Re: [PATCH v4 18/23] iommu/arm-smmu-v3-iommufd: Support implementation-defined hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCd3L5h6/D4bgY1z@Asurada-Nvidia>
Date: Fri, 16 May 2025 10:34:39 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <corbet@....net>, <will@...nel.org>,
	<bagasdotme@...il.com>, <robin.murphy@....com>, <joro@...tes.org>,
	<thierry.reding@...il.com>, <vdumpa@...dia.com>, <jonathanh@...dia.com>,
	<shuah@...nel.org>, <jsnitsel@...hat.com>, <nathan@...nel.org>,
	<peterz@...radead.org>, <yi.l.liu@...el.com>, <mshavit@...gle.com>,
	<praan@...gle.com>, <zhangzekun11@...wei.com>, <iommu@...ts.linux.dev>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-tegra@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <patches@...ts.linux.dev>,
	<mochs@...dia.com>, <alok.a.tiwari@...cle.com>, <vasant.hegde@....com>
Subject: Re: [PATCH v4 18/23] iommu/arm-smmu-v3-iommufd: Support
 implementation-defined hw_info

On Fri, May 16, 2025 at 10:22:57AM -0300, Jason Gunthorpe wrote:
> On Thu, May 15, 2025 at 01:17:47PM -0700, Nicolin Chen wrote:
> > > I think the former is simpler to code, you can just add the req_type
> > > to the signatures and if the driver comes back with a type != req_type
> > > the core code will return EOPNOTSUPP
> > 
> > OK.
> > 
> > Maybe just turn the out_data_type to be bidirectional?
> 
> You can do that, bu you need to add a flag to turn it on.  We didn't
> validate that it was 0 on input before so we can't start now.

Sure. I feel adding a flag would have less footprints throughout
the call down to the driver. Will try doing that.

Thanks
Nicolin