linux-kernel - Re: [PATCH] rust: add basic ELF sections parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08a91cb8-2e08-44a5-9d5c-c2c223aaa71d@nvidia.com>
Date: Fri, 16 May 2025 12:00:11 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>,
 Alexandre Courbot <acourbot@...dia.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, Timur Tabi <timur@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: add basic ELF sections parser

On 5/16/25 9:01 AM, Danilo Krummrich wrote:
> On Fri, May 16, 2025 at 11:35:42PM +0900, Alexandre Courbot wrote:
>> On Fri May 16, 2025 at 10:35 PM JST, Danilo Krummrich wrote:
...
>> Now the GSP firmware for GA102 contains the following sections (skipped
>> the ones that don't need to be extracted):
>>
>>    [ 1] .fwimage          PROGBITS         0000000000000000  00000040
>>    [ 2] .fwversion        PROGBITS         0000000000000000  02448040
>>    [ 3] .fwsignature[...] PROGBITS         0000000000000000  0244804b
>>    [ 4] .fwsignature[...] PROGBITS         0000000000000000  0244904b
>>    [ 5] .fwsignature[...] PROGBITS         0000000000000000  0244a04b
>>    [ 6] .fwsignature[...] PROGBITS         0000000000000000  0244b04b
>>
>> That's 6 files instead of 1, for serving the same purpose. And the number of

gaahhh!

We are already at 252 files, *before* artificially exploding the GSP
into sub-files:

$ find /lib/firmware/nvidia -type f | wc -l
252

...
>> I would push back really hard on that one, unless you agree to go after all the
>> drivers that do the same thing (and I have names).
> 
> Great, but then why did you back off in your discussion with Greg? Given that
> you are convinced that this is a valid thing to do for drivers, you should keep
> discussing it with the target to make it common infrastructure.
> 

One way forward would be to apply this to one or two other drivers.
Alex, you said you have names, can you please list those names here?

> I did not argue for or against it -- what I do disagree with is that we seem to
> just agree to disagree and stuff a generic piece of code into nova-core after
> three mails back and forth.
> 
> Please keep discussing the above with Greg until we get to a real conclusion.
> 
> - Danilo

Danilo, this is a small amount of code. Is there any real problem with
a compromise, that starts out with Greg's approach of putting this code
in Nova?

And then we can promote it if and when we can make a good case for that.

But in the meantime, we really need to be able to take "yes" (from Greg)
for an answer! I don't want to blow up the firmware images, shred
the "Nouveau and Nova can use the same images" story, and delay merging,
all over 100 lines of code.

Yes?

thanks,
-- 
John Hubbard