linux-kernel - [RFC PATCH v2 03/13] KVM: guest_mem: Refactor out kvm_gmem_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322a07a0eaad85938446a561d868cfcad7b4ecb.1747368092.git.afranji@google.com>
Date: Fri, 16 May 2025 19:19:23 +0000
From: Ryan Afranji <afranji@...gle.com>
To: afranji@...gle.com, ackerleytng@...gle.com, pbonzini@...hat.com, 
	seanjc@...gle.com, tglx@...utronix.de, x86@...nel.org, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	tabba@...gle.com
Cc: mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com, 
	shuah@...nel.org, andrew.jones@...ux.dev, ricarkol@...gle.com, 
	chao.p.peng@...ux.intel.com, jarkko@...nel.org, yu.c.zhang@...ux.intel.com, 
	vannapurve@...gle.com, erdemaktas@...gle.com, mail@...iej.szmigiero.name, 
	vbabka@...e.cz, david@...hat.com, qperret@...gle.com, michael.roth@....com, 
	wei.w.wang@...el.com, liam.merwick@...cle.com, isaku.yamahata@...il.com, 
	kirill.shutemov@...ux.intel.com, sagis@...gle.com, jthoughton@...gle.com
Subject: [RFC PATCH v2 03/13] KVM: guest_mem: Refactor out kvm_gmem_alloc_view()

From: Ackerley Tng <ackerleytng@...gle.com>

kvm_gmem_alloc_view() will allocate and build a file out of an inode.

Will be reused later by kvm_gmem_link()

Signed-off-by: Ackerley Tng <ackerleytng@...gle.com>
Co-developed-by: Ryan Afranji <afranji@...gle.com>
Signed-off-by: Ryan Afranji <afranji@...gle.com>
---
 virt/kvm/guest_memfd.c | 61 +++++++++++++++++++-----------------------
 1 file changed, 27 insertions(+), 34 deletions(-)

diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
index 2ee26695dc31..a3918d1695b9 100644
--- a/virt/kvm/guest_memfd.c
+++ b/virt/kvm/guest_memfd.c
@@ -470,49 +470,47 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name,
 	return inode;
 }
 
-static struct file *kvm_gmem_inode_create_getfile(void *priv, loff_t size,
-						  u64 flags)
+static struct file *kvm_gmem_alloc_view(struct kvm *kvm, struct inode *inode,
+				     const char *name)
 {
-	static const char *name = "[kvm-gmem]";
-	struct inode *inode;
+	struct kvm_gmem *gmem;
 	struct file *file;
-	int err;
 
-	err = -ENOENT;
 	if (!try_module_get(kvm_gmem_fops.owner))
-		goto err;
+		return ERR_PTR(-ENOENT);
 
-	inode = kvm_gmem_inode_make_secure_inode(name, size, flags);
-	if (IS_ERR(inode)) {
-		err = PTR_ERR(inode);
+	gmem = kzalloc(sizeof(*gmem), GFP_KERNEL);
+	if (!gmem) {
+		file = ERR_PTR(-ENOMEM);
 		goto err_put_module;
 	}
 
 	file = alloc_file_pseudo(inode, kvm_gmem_mnt, name, O_RDWR,
 				 &kvm_gmem_fops);
-	if (IS_ERR(file)) {
-		err = PTR_ERR(file);
-		goto err_put_inode;
-	}
+	if (IS_ERR(file))
+		goto err_gmem;
 
 	file->f_flags |= O_LARGEFILE;
-	file->private_data = priv;
+	file->private_data = gmem;
+
+	kvm_get_kvm(kvm);
+	gmem->kvm = kvm;
+	xa_init(&gmem->bindings);
+	list_add(&gmem->entry, &file_inode(file)->i_mapping->i_private_list);
 
-out:
 	return file;
 
-err_put_inode:
-	iput(inode);
+err_gmem:
+	kfree(gmem);
 err_put_module:
 	module_put(kvm_gmem_fops.owner);
-err:
-	file = ERR_PTR(err);
-	goto out;
+	return file;
 }
 
 static int __kvm_gmem_create(struct kvm *kvm, loff_t size, u64 flags)
 {
-	struct kvm_gmem *gmem;
+	static const char *name = "[kvm-gmem]";
+	struct inode *inode;
 	struct file *file;
 	int fd, err;
 
@@ -520,28 +518,23 @@ static int __kvm_gmem_create(struct kvm *kvm, loff_t size, u64 flags)
 	if (fd < 0)
 		return fd;
 
-	gmem = kzalloc(sizeof(*gmem), GFP_KERNEL);
-	if (!gmem) {
-		err = -ENOMEM;
+	inode = kvm_gmem_inode_make_secure_inode(name, size, flags);
+	if (IS_ERR(inode)) {
+		err = PTR_ERR(inode);
 		goto err_fd;
 	}
 
-	file = kvm_gmem_inode_create_getfile(gmem, size, flags);
+	file = kvm_gmem_alloc_view(kvm, inode, name);
 	if (IS_ERR(file)) {
 		err = PTR_ERR(file);
-		goto err_gmem;
+		goto err_put_inode;
 	}
 
-	kvm_get_kvm(kvm);
-	gmem->kvm = kvm;
-	xa_init(&gmem->bindings);
-	list_add(&gmem->entry, &file_inode(file)->i_mapping->i_private_list);
-
 	fd_install(fd, file);
 	return fd;
 
-err_gmem:
-	kfree(gmem);
+err_put_inode:
+	iput(inode);
 err_fd:
 	put_unused_fd(fd);
 	return err;
-- 
2.49.0.1101.gccaa498523-goog