linux-kernel - Re: [PATCH 2/7] dt-bindings: soc: ti: pruss: Add documentation for PRU UART support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29e4e325-dac9-4454-9d5f-9521cc3d1865@ti.com>
Date: Fri, 16 May 2025 17:33:17 -0500
From: Judith Mendez <jm@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Santosh
 Shilimkar <ssantosh@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Bin Liu <b-liu@...com>,
        Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>,
        Andrew Davis <afd@...com>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/7] dt-bindings: soc: ti: pruss: Add documentation for
 PRU UART support

On 5/14/25 7:35 AM, Krzysztof Kozlowski wrote:
> On 13/05/2025 23:59, Judith Mendez wrote:
>> Add documentation for PRU UART node which is for PRU serial UART
>> based-off the industry standard TL16C550 asynchronous communications
>> element.
>>
>> Signed-off-by: Judith Mendez <jm@...com>
>> ---
>>   Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
> 
> Nothing in cover letter explains dependency and this the most important
> part of cover letter. Otherwise how maintainers are supposed to guess
> what they can take and what cannot?
> 
> Squash the patch with previous in such case.

Sure can do.

> 
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> index 927b3200e29e..54397297cbf5 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> @@ -324,6 +324,13 @@ patternProperties:
>>       $ref: /schemas/net/ti,davinci-mdio.yaml#
>>       type: object
>>   
>> +  serial@[a-f0-9]+$:
>> +    description: |
> 
> Do not need '|' unless you need to preserve formatting.

Will fix this and first patch as well.

Thanks

~ Judith