linux-kernel - Re: [PATCH v2 0/6] PCI: Remove hybrid-devres region requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d399dd38-b26f-413f-ab02-49680ff87ed1@linux.intel.com>
Date: Fri, 16 May 2025 16:14:47 -0700
From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Philipp Stanner <phasta@...nel.org>, Jonathan Corbet <corbet@....net>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Mark Brown <broonie@...nel.org>,
 David Lechner <dlechner@...libre.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Zijun Hu <quic_zijuhu@...cinc.com>, Yang Yingliang
 <yangyingliang@...wei.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Krzysztof Wilczyński <kw@...ux.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 0/6] PCI: Remove hybrid-devres region requests


On 5/16/25 10:41 AM, Philipp Stanner wrote:
> Changes in v2:
>    - Drop patch for removing forgotten header. Patch is unrelated. Will
>      resend seperately. (Andy)
>    - Make docu patch headline "Documentation/driver-api:". There seems to
>      be no canonical way, but this style is quite frequent. (Andy)
>    - Apply Andy's RBs where applicable.
>
> Howdy,
>
> the great day has finally arrived, I managed to get rid of one of the
> big three remaining problems in the PCI devres API (the other two being
> MSI having hybrid-devres, too, and the good old pcim_iomap_tablle)!
>
> It turned out that there aren't even that many users of the hybrid API,
> where pcim_enable_device() switches certain functions in pci.c into
> managed devres mode, which we want to remove.
>
> The affected drivers can be found with:
>
> grep -rlZ "pcim_enable_device" | xargs -0 grep -l "pci_request"
>
> These were:
>
> 	ASoC [1]
> 	alsa [2]
> 	cardreader [3]
> 	cirrus [4]
> 	i2c [5]
> 	mmc [6]
> 	mtd [7]
> 	mxser [8]
> 	net [9]
> 	spi [10]
> 	vdpa [11]
> 	vmwgfx [12]
>
> All of those have been merged and are queued up for the merge window.
> The only possible exception is vdpa, but it seems to be ramped up right
> now; vdpa, however, doesn't even use the hybrid behavior, so that patch
> is just for generic cleanup anyways.
>
> With the users of the hybrid feature gone, the feature itself can
> finally be burned.
>
> So I'm sending out this series now to probe whether it's judged to be
> good enough for the upcoming merge window. If we could take it, we would
> make it impossible that anyone adds new users of the hybrid thing.
>
> If it's too late for the merge window, then that's what it is, of
> course.
>
> In any case I'm glad we can get rid of most of that legacy stuff now.

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@...ux.intel.com>


>
> Regards,
> Philipp
>
> [1] https://lore.kernel.org/all/174657893832.4155013.12131767110464880040.b4-ty@kernel.org/
> [2] https://lore.kernel.org/all/8734dy3tvz.wl-tiwai@suse.de/
> [3] https://lore.kernel.org/all/20250417091532.26520-2-phasta@kernel.org/ (private confirmation mail from Greg KH)
> [4] https://lore.kernel.org/dri-devel/e7c45c099f8981257866396e01a91df1afcfbf97.camel@mailbox.org/
> [5] https://lore.kernel.org/all/l26azmnpceka2obq4gtwozziq6lbilb2owx57aajtp3t6jhd3w@llmeikgjvqyh/
> [6] https://lore.kernel.org/all/CAPDyKFqqV2VEqi17UHmFE0b9Y+h5q2YaNfHTux8U=7DgF+svEw@mail.gmail.com/
> [7] https://lore.kernel.org/all/174591865790.993381.15992314896975862083.b4-ty@bootlin.com/
> [8] https://lore.kernel.org/all/20250417081333.20917-2-phasta@kernel.org/ (private confirmation mail from Greg KH)
> [9] https://lore.kernel.org/all/174588423950.1081621.6688170836136857875.git-patchwork-notify@kernel.org/
> [10] https://lore.kernel.org/all/174492457740.248895.3318833401427095151.b4-ty@kernel.org/
> [11] https://lore.kernel.org/all/20250515072724-mutt-send-email-mst@kernel.org/
> [12] https://lore.kernel.org/dri-devel/CABQX2QNQbO4dMq-Hi6tvpi7OTwcVfjM62eCr1OGkzF8Phy-Shw@mail.gmail.com/
>
> Philipp Stanner (6):
>    PCI: Remove hybrid devres nature from request functions
>    Documentation/driver-api: Update pcim_enable_device()
>    PCI: Remove pcim_request_region_exclusive()
>    PCI: Remove request_flags relict from devres
>    PCI: Remove redundant set of request funcs
>    PCI: Remove hybrid-devres hazzard warnings from doc
>
>   .../driver-api/driver-model/devres.rst        |   2 +-
>   drivers/pci/devres.c                          | 201 +++---------------
>   drivers/pci/iomap.c                           |  16 --
>   drivers/pci/pci.c                             |  42 ----
>   drivers/pci/pci.h                             |   3 -
>   5 files changed, 32 insertions(+), 232 deletions(-)
>
-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer