linux-kernel - Re: [PATCH v1 net] net: lan743x: Restore SGMII CTRL register on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516164010.49dd5e8b@kernel.org>
Date: Fri, 16 May 2025 16:40:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Thangaraj Samynathan <thangaraj.s@...rochip.com>
Cc: <bryan.whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
 <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net] net: lan743x: Restore SGMII CTRL register on
 resume

On Fri, 16 May 2025 09:27:19 +0530 Thangaraj Samynathan wrote:
> SGMII_CTRL register, which specifies the active interface, was not 
> properly restored when resuming from suspend. This led to incorrect
> interface selection after resume particularly in scenarios involving
> the FPGA.
> 
> To fix this:
> - Move the SGMII_CTRL setup out of the probe function.
> - Initialize the register in the hardware initialization helper function,
> which is called during both device initialization and resume.
> 
> This ensures the interface configuration is consistently restored after
> suspend/resume cycles.

Is there a reason you're not CCing Raju Lakkaraju on this?
Having a review tag from the author of the change under Fixes 
is always great.