linux-kernel - Re: [PATCH] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPwXWsD2JHO+MQS5+5+Zi8ic4uFY6G24Ug2Jd2dZ3zfSDvuxtQ@mail.gmail.com>
Date: Fri, 16 May 2025 11:41:29 +0800
From: 陳子潔 <shawn2000100@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: mathias.nyman@...el.com, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: xhci: Set avg_trb_len = 8 for EP0 during Address
 Device Command

Hi Greg,

I got it, thank you so much for the effort!

I already patched a newer version
Link: https://lore.kernel.org/linux-usb/20250516033908.7386-1-shawn2000100@gmail.com/T/#u


On Wed, May 14, 2025 at 10:46 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, May 14, 2025 at 09:40:08PM +0800, jay.chen wrote:
> > According to the xHCI 1.2 spec (Section 6.2.3, p.454), the Average
> > TRB Length (avg_trb_len) for control endpoints should be set to 8.
> >
> > Currently, during the Address Device Command, EP0's avg_trb_len remains 0,
> > which may cause some xHCI hardware to reject the Input Context, resulting
> > in device enumeration failures. In extreme cases, using a zero avg_trb_len
> > in calculations may lead to division-by-zero errors and unexpected system
> > crashes.
> >
> > This patch sets avg_trb_len to 8 for EP0 in
> > xhci_setup_addressable_virt_dev(), ensuring compliance with the spec
> > and improving compatibility across various host controller implementations.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=220033
> > Signed-off-by: jay.chen <shawn2000100@...il.com>
>
> Please use your name, not your email alias.
>
> And as you are now using a gmail account, please set the "From:" line at
> the top of the patch properly as is documented.  Please work with others
> at your company that know how to do all of this if you have questions.
>
> Also, this is a v2 patch, so always document what changed to warrant a
> new version.
>
> thanks,
>
> greg k-h